Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove mustsortjson usuage #5395

Merged
merged 5 commits into from
Dec 20, 2023

Conversation

chandiniv1
Copy link
Contributor

closes: #3919

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (7c48b96) 80.12% compared to head (69a7a8d) 80.10%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5395      +/-   ##
==========================================
- Coverage   80.12%   80.10%   -0.02%     
==========================================
  Files         189      189              
  Lines       13140    13143       +3     
==========================================
  Hits        10528    10528              
- Misses       2199     2202       +3     
  Partials      413      413              
Files Coverage Δ
modules/apps/29-fee/types/ack.go 0.00% <0.00%> (ø)

@crodriguezvega
Copy link
Contributor

crodriguezvega commented Dec 14, 2023

@chandiniv1 Thank you so much for contributing to ibc-go and for opening so many PRs already! We are extremely busy at the moment wrapping up some important work before the end of the year (for 08-wasm and channel upgradability), and therefore we might not be able to dedicate enough time to review your PRs until the new year. Apologies for that, but we hope that you understand.

We also wanted to ask you that, in the future, when you would like to pick up an issue, you comment on it first. This is part of the process that we have outlined in our contributing guidelines. This is a very useful signalling mechanism, so that we prevent situations where multiple people might be working on the same issue. If you could do that next time you would like to work on an issue, we would appreciate that greatly. Thank you!

@chandiniv1
Copy link
Contributor Author

@chandiniv1 Thank you so much for contributing to ibc-go and for opening so many PRs already! We are extremely busy at the moment wrapping up some important work before the end of the year (for 08-wasm and channel upgradability), and therefore we might not be able to dedicate enough time to review your PRs until the new year. Apologies for that, but we hope that you understand.

We also wanted to ask you that, in the future, when you would like to pick up an issue, you comment on it first. This is part of the process that we have outlined in our contributing guidelines. This is a very useful signalling mechanism, so that we prevent situations where multiple people might be working on the same issue. If you could do that next time you would like to work on an issue, we would appreciate that greatly. Thank you!

okay thank you @crodriguezvega

modules/apps/29-fee/types/ack.go Outdated Show resolved Hide resolved
modules/apps/29-fee/types/ack.go Show resolved Hide resolved
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@crodriguezvega crodriguezvega merged commit 3fadc29 into cosmos:main Dec 20, 2023
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove sdk.MustSortJSON from ics29 acknowledgement.Acknowledgement()
4 participants