Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sdk.MustSortJSON from ics29 acknowledgement.Acknowledgement() #3919

Closed
3 tasks
Tracked by #3916
colin-axner opened this issue Jun 21, 2023 · 0 comments · Fixed by #5395
Closed
3 tasks
Tracked by #3916

Remove sdk.MustSortJSON from ics29 acknowledgement.Acknowledgement() #3919

colin-axner opened this issue Jun 21, 2023 · 0 comments · Fixed by #5395
Labels
help wanted Issues for which we would appreciate help/support from the community type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@colin-axner
Copy link
Contributor

Summary

Same reasoning as #3915, the sorting will not change the counterparties ability to decode the acknowledgement

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the type: code hygiene Clean up code but without changing functionality or interfaces label Jun 21, 2023
@colin-axner colin-axner mentioned this issue Jun 21, 2023
Closed
9 tasks
@crodriguezvega crodriguezvega added the help wanted Issues for which we would appreciate help/support from the community label Nov 14, 2023
@chandiniv1 chandiniv1 mentioned this issue Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issues for which we would appreciate help/support from the community type: code hygiene Clean up code but without changing functionality or interfaces
Projects
ibc-go
Status: Done 🥳
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove mustsortjson usuage chandiniv1/ibc-go
2 participants
@crodriguezvega @colin-axner