Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: push docker image on betas #22189

Merged
merged 2 commits into from
Oct 9, 2024
Merged

ci: push docker image on betas #22189

merged 2 commits into from
Oct 9, 2024

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Oct 9, 2024

Description

ref: https://github.com/cosmos/cosmos-sdk/pkgs/container/simapp

fixes https://github.com/cosmos/cosmos-sdk/actions/runs/11253316267/job/31288315521 as well


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features
    • Enhanced version tag recognition to support beta and more flexible release candidate tags in the deployment workflow.

These improvements allow for better handling of various pre-release versions, ensuring a smoother deployment process.

  • Bug Fixes
    • Removed the auth module from the Docker build context, streamlining the build process for the simd application.

Copy link
Contributor

coderabbitai bot commented Oct 9, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The changes in the .github/workflows/docker.yml file involve updates to the regex patterns for version tags in the push event configuration. The modifications enhance the workflow's capability to recognize additional versioning schemes, specifically for release candidates and beta versions, by refining existing patterns and introducing a new one for beta tags. Additionally, modifications in the Dockerfile and contrib/images/simd-env/Dockerfile focus on the build process, notably removing the auth module from the build context.

Changes

File Change Summary
.github/workflows/docker.yml Updated regex for version tags: no change to main version pattern; modified release candidate pattern; added beta version pattern.
Dockerfile, contrib/images/simd-env/Dockerfile Removed COPY commands for x/auth/go.mod and x/auth/go.sum, affecting authentication functionality.

Suggested labels

Type: CI

Suggested reviewers

  • auricom
  • sontrinh16
  • tac0turtle

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between ecdd074 and 5335ad7.

📒 Files selected for processing (2)
  • Dockerfile (0 hunks)
  • contrib/images/simd-env/Dockerfile (0 hunks)
💤 Files with no reviewable changes (2)
  • Dockerfile
  • contrib/images/simd-env/Dockerfile

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
.github/workflows/docker.yml (1)

14-14: Good addition of beta version tag support.

The new pattern "v[0-9]+.[0-9]+.[0-9]+-beta.*" is a valuable addition that enables the workflow to recognize beta version tags. This is consistent with the existing versioning scheme and expands the workflow's capabilities to handle beta releases.

For improved consistency and flexibility, consider using a more generic pre-release pattern:

- "v[0-9]+.[0-9]+.[0-9]+-(rc|beta|alpha).*"

This pattern would cover release candidates, beta versions, and potential alpha releases, making the workflow more adaptable to future pre-release naming conventions.

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 3220aab and ecdd074.

📒 Files selected for processing (1)
  • .github/workflows/docker.yml (1 hunks)
🧰 Additional context used
🔇 Additional comments (3)
.github/workflows/docker.yml (3)

12-12: LGTM: Semantic version tag pattern is correct.

The pattern "v[0-9]+.[0-9]+.[0-9]+" correctly matches standard semantic version tags (e.g., v1.0.0, v20.15.10). This ensures that the workflow will trigger for all major, minor, and patch releases.


13-13: Improved pattern for release candidate tags.

The update from "v[0-9]+.[0-9]+.[0-9]+-rc*" to "v[0-9]+.[0-9]+.[0-9]+-rc.*" is a good improvement. This change ensures that:

  1. There's at least one character after "rc", preventing matches with incomplete tags like "v1.0.0-rc".
  2. It allows for more flexible numbering schemes for release candidates, such as "v1.0.0-rc.1" or "v1.0.0-rc.alpha".

This modification enhances the precision of release candidate tag matching.


12-14: Summary: Improved version tag handling aligns with PR objectives.

The changes to the docker.yml workflow file successfully enhance the CI configuration to handle a broader range of version tags, including beta versions. This aligns well with the PR objective of pushing Docker images for beta environments.

Key improvements:

  1. Refined release candidate tag pattern for more precise matching.
  2. Added support for beta version tags.

These changes will allow the workflow to trigger appropriately for various pre-release versions, facilitating the deployment of Docker images to beta environments as intended.

Consider the earlier suggestion to use a more generic pre-release pattern for even greater flexibility in the future.

Overall, these modifications effectively support the PR's goal of improving the development workflow within the Cosmos SDK project.

@julienrbrt julienrbrt requested a review from a team as a code owner October 9, 2024 10:57
@julienrbrt julienrbrt added the backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release label Oct 9, 2024
@julienrbrt julienrbrt added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit 91c0e79 Oct 9, 2024
77 checks passed
@julienrbrt julienrbrt deleted the julien/docker branch October 9, 2024 15:26
mergify bot pushed a commit that referenced this pull request Oct 9, 2024
julienrbrt added a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release Type: Build Type: CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants