-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: push docker image on betas #22189
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe changes in the Changes
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yml 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.github/workflows/docker.yml (1)
14-14
: Good addition of beta version tag support.The new pattern
"v[0-9]+.[0-9]+.[0-9]+-beta.*"
is a valuable addition that enables the workflow to recognize beta version tags. This is consistent with the existing versioning scheme and expands the workflow's capabilities to handle beta releases.For improved consistency and flexibility, consider using a more generic pre-release pattern:
- "v[0-9]+.[0-9]+.[0-9]+-(rc|beta|alpha).*"
This pattern would cover release candidates, beta versions, and potential alpha releases, making the workflow more adaptable to future pre-release naming conventions.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
📒 Files selected for processing (1)
- .github/workflows/docker.yml (1 hunks)
🧰 Additional context used
🔇 Additional comments (3)
.github/workflows/docker.yml (3)
12-12
: LGTM: Semantic version tag pattern is correct.The pattern
"v[0-9]+.[0-9]+.[0-9]+"
correctly matches standard semantic version tags (e.g., v1.0.0, v20.15.10). This ensures that the workflow will trigger for all major, minor, and patch releases.
13-13
: Improved pattern for release candidate tags.The update from
"v[0-9]+.[0-9]+.[0-9]+-rc*"
to"v[0-9]+.[0-9]+.[0-9]+-rc.*"
is a good improvement. This change ensures that:
- There's at least one character after "rc", preventing matches with incomplete tags like "v1.0.0-rc".
- It allows for more flexible numbering schemes for release candidates, such as "v1.0.0-rc.1" or "v1.0.0-rc.alpha".
This modification enhances the precision of release candidate tag matching.
12-14
: Summary: Improved version tag handling aligns with PR objectives.The changes to the
docker.yml
workflow file successfully enhance the CI configuration to handle a broader range of version tags, including beta versions. This aligns well with the PR objective of pushing Docker images for beta environments.Key improvements:
- Refined release candidate tag pattern for more precise matching.
- Added support for beta version tags.
These changes will allow the workflow to trigger appropriately for various pre-release versions, facilitating the deployment of Docker images to beta environments as intended.
Consider the earlier suggestion to use a more generic pre-release pattern for even greater flexibility in the future.
Overall, these modifications effectively support the PR's goal of improving the development workflow within the Cosmos SDK project.
(cherry picked from commit 91c0e79)
Co-authored-by: Julien Robert <[email protected]>
Description
ref: https://github.com/cosmos/cosmos-sdk/pkgs/container/simapp
fixes https://github.com/cosmos/cosmos-sdk/actions/runs/11253316267/job/31288315521 as well
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
These improvements allow for better handling of various pre-release versions, ensuring a smoother deployment process.
auth
module from the Docker build context, streamlining the build process for thesimd
application.