fix(staking): avoid the double iterator close in staking

[cool-develope]

Description

Fixed the small issue of the double iterator being close in staking. The given iterator is closed in CollectValues,

cosmos-sdk/collections/indexes/helpers.go

Line 93 in bdda21f

defer iter.Close()

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• Bug Fixes
  • Addressed potential resource management issues related to iterator handling in the staking module.

[coderabbitai]

Walkthrough

Walkthrough

The pull request modifies the GetBlockConsPubKeyRotationHistory function in the x/staking/keeper/cons_pubkey.go file by removing the defer iterator.Close() statement. This change impacts resource management by eliminating the automatic closure of the iterator, which may lead to potential resource leaks if the iterator is not closed elsewhere in the code.

Changes

File	Change Summary
x/staking/keeper/cons_pubkey.go	Removed defer iterator.Close() from GetBlockConsPubKeyRotationHistory, affecting iterator management.

Possibly related PRs

• fix(stf/branch/memiter): Fix Iter validity #21556: This PR addresses the validity of an iterator after it has been closed, directly relating to iterator lifecycle management.

Suggested labels

C:server/v2, C:server/v2 stf

---

Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b9bb000 and c1eb599.

Files selected for processing (1)

• x/staking/keeper/cons_pubkey.go (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• x/staking/keeper/cons_pubkey.go

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

@cool-develope your pull request is missing a changelog!

[julienrbrt]

Can we add a comment?

[cool-develope]

not sure if the comment is needed

[julienrbrt]

not sure if the comment is needed

It was mostly in case contributors add this, and we miss it in a PR (as without checking out the code, it makes sense to defer close an iterator). Feel free to ignore if you rather not add it.