feat(testutil/integration): allow to pass baseapp options

[julienrbrt]

Description

Extending the integration app with custom handlers wasn't possible before.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• New Features

  • Enhanced error messages for genesis validation in the genutil module.
  • Introduction of the sims2 framework and factory methods in the sims module for easier message factory creation.
  • Ability to customize NewIntegrationApp with additional baseapp options for improved flexibility.

• Improvements

  • Overall enhancements to the functionality and usability of the respective modules.

[coderabbitai]

Walkthrough

Walkthrough

The pull request introduces several enhancements across multiple modules in the codebase. Key changes include improved error messages for genesis validation in the genutil module, the addition of the sims2 framework and factory methods in the sims module, and the modification of the NewIntegrationApp function in the testutil/integration module to accept additional baseapp options. These changes aim to improve clarity, flexibility, and usability within the respective modules.

Changes

File	Change Summary
CHANGELOG.md	Added entries for improved error messages in genutil, sims2 framework in sims, and baseapp options in testutil/integration.
testutil/integration/router.go	Modified NewIntegrationApp to include a variadic parameter for baseapp options, enhancing flexibility.

Possibly related PRs

• feat(x/genutil): add better error messages for genesis validation #21701: This PR enhances error messages for genesis validation in the genutil module, which is directly related to the improvements made in the main PR regarding error messages for genesis validation.

Suggested labels

C:x/genutil, C:Store, C:CLI, C:x/accounts, C:indexer/postgres

Suggested reviewers

• kocubinski
• julienrbrt
• hieuvubk
• tac0turtle
• cool-develope

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

CHANGELOG.md (1)

53-54: Minor inconsistency in abbreviations

The release notes are very well structured and detailed. One small inconsistency is the use of both "applications" and "apps". Consider standardizing on one or the other for clarity.

Overall the categorization, descriptions and PR links make these excellent release notes!

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c9b90ad and 54de2fa.

Files selected for processing (2)

• CHANGELOG.md (1 hunks)
• testutil/integration/router.go (2 hunks)

Additional context used

Path-based instructions (2)

CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

testutil/integration/router.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Additional comments not posted (2)

testutil/integration/router.go (1)

58-58: LGTM!

The addition of the variadic parameter baseAppOptions to the NewIntegrationApp function and its usage in the baseapp.NewBaseApp constructor enhances the flexibility of creating a BaseApp instance for testing purposes. This change allows users to customize the behavior of the BaseApp without modifying the core logic of the application.

The change is backward compatible and provides more flexibility to the users of the function.

Also applies to: 67-67

CHANGELOG.md (1)

Line range hint 1-1253: Excellent changelog overall

This is an exemplary changelog for a large project. The structure, categorization, and links back to PRs are all helpful for users and contributors.

Aside from the small inconsistency in abbreviations mentioned above, this is a thorough and well-maintained record of changes. Great work!