Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo #21815

Merged
merged 1 commit into from
Sep 19, 2024
Merged

docs: fix typo #21815

merged 1 commit into from
Sep 19, 2024

Conversation

hattizai
Copy link
Contributor

@hattizai hattizai commented Sep 19, 2024

Description

demon -> denom

Summary by CodeRabbit

  • Bug Fixes
    • Corrected typographical errors in comments and test cases, changing "demon" to "denom" for clarity and accuracy.
    • Ensured consistency in terminology used for coin denominations across documentation and tests.

Copy link
Contributor

coderabbitai bot commented Sep 19, 2024

Walkthrough

Walkthrough

The changes in this pull request consist of minor textual corrections in comments across several files. Specifically, the term "demon" has been corrected to "denom" in various functions and structs. These modifications are purely typographical and do not impact the functionality or logic of the code.

Changes

File Path Change Summary
x/bank/simulation/genesis.go Corrected "demon" to "denom" in a comment within the RandomGenesisSendEnabled function.
x/bank/types/genesis.go Corrected "demon" to "denom" in comments of the MigrateSendEnabled function.
x/tx/signing/aminojson/aminojson_test.go Renamed coin denomination from "demon" to "denom" in the TestAminoJsonSignMode function.
x/tx/signing/aminojson/fuzz_test.go Modified Denom field from "demon" to "denom" in the FuzzSignModeGetSignBytes function.

Possibly related PRs

Suggested labels

C:server/v2, C:schema, C:server/v2 cometbft

Suggested reviewers

  • sontrinh16
  • julienrbrt
  • tac0turtle

Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b8014df and 45db981.

Files selected for processing (4)
  • x/bank/simulation/genesis.go (1 hunks)
  • x/bank/types/genesis.go (1 hunks)
  • x/tx/signing/aminojson/aminojson_test.go (1 hunks)
  • x/tx/signing/aminojson/fuzz_test.go (1 hunks)
Files skipped from review due to trivial changes (4)
  • x/bank/simulation/genesis.go
  • x/bank/types/genesis.go
  • x/tx/signing/aminojson/aminojson_test.go
  • x/tx/signing/aminojson/fuzz_test.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@julienrbrt julienrbrt added this pull request to the merge queue Sep 19, 2024
Merged via the queue into cosmos:main with commit 8d5020f Sep 19, 2024
72 of 73 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Sep 20, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants