Add CI action to test endpoints from whitelisted chains and providers #5427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
approved these changes
Oct 5, 2024
_tests/test_endpoints.py
Outdated
| with open(filename) as f: | ||
| data = json.load(f) | ||
| chain_name = data.get('chain_name', 'unknown') | ||
| if 'apis' in data: |
There was a problem hiding this comment.
Might be helpful to print some warnings if this condition is false in case the structure changes and we start skipping the entries.
Applies to other if statements below too
_tests/test_endpoints.py
Outdated
| return test_cases | ||
|
|
||
| test_cases = generate_endpoint_tests() | ||
| if test_cases: |
There was a problem hiding this comment.
Why do we need this check? Is it ever expected to not pass?
_tests/test_endpoints.py
Outdated
Comment on lines
21
to
33
| "axelar", | ||
| "celestia", | ||
| "composable", | ||
| "cosmoshub", | ||
| "dydx", | ||
| "dymension", | ||
| "evmos", | ||
| "injective", | ||
| "neutron", | ||
| "noble", | ||
| "osmosis", | ||
| "stargaze", | ||
| "stride" |
There was a problem hiding this comment.
If we want to ensure that our CI passes only when all providers are processed, we could also keep a tally of the number of successful chains validated, checking that it matches the length of the whitelisted chains at the end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a github action to do a simple smoke test of the RPC and LCD endpoints offered in the chain registry.
This is how it looks like:
https://github.com/pablin-10/chain-registry/actions/runs/11265464331
By now only tests providers whitelisted in the test itself:
We may configure it to run every day or every week since it may take a lot of time to run for all the chains and providers if whitelist disabled.