Add data binding support for "complete_icon" and "slider_icon" attributes #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortinico
force-pushed
the
data_binding_support
branch
from
5e6ee3e
to
4cd6b9e
Compare
cortinico
requested changes
Jun 3, 2022
| @@ -156,17 +156,34 @@ class SlideToActView @JvmOverloads constructor( | |||
| } | |||
|
|
|||
| /** Custom Slider Icon */ | |||
| @DrawableRes | |||
| var sliderIcon: Int = R.drawable.slidetoact_ic_arrow | |||
| var sliderIcon: Any = R.drawable.slidetoact_ic_arrow | |||
There was a problem hiding this comment.
This is sadly suboptimal :/
We're now exposing a public property which is a Any.
I think we should instead create other two private fields called:
private var sliderIconDrawable
private var completeIconDrawable
And let the BindingAdapter operate on those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
complete_iconandslider_iconattributes are@DrawableRes Intvariables. To be set up via Data binding they should also support theDrawabletype.Related PRs/Issues
#156
Todos