Update #ramp_down_apk: Small text and title changes #3455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you also change the grammar in the last sentence? "Please note, support for this setup will not be provided by BMG and RKI." That should be "Please note, support for this setup will not be provided by BMG or RKI." It would only be "and" if they were providing support. Since they are not offering support, then "or" is the better choice. I think the German text with "und" is OK however, since it is worded differently (as in BMG and RKI stand together in deciding that they will not offer support). |
|
|
Thanks for your suggestion, I have changed it in b2dc762 for both the English and German text. We think this wouldn't make it worse in German. |
larswmh
changed the title
dsarkar
approved these changes
Mar 30, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the English FAQ title of #ramp_down_apk to match with the German title by removing the word "still". In addition to that, the last sentence was slightly changed. See #3455 (comment)