Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm64 #1070

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Arm64 #1070

wants to merge 5 commits into from

Conversation

wsobolewski
Copy link

Support windows-arm64.

Copy link

github-actions bot commented Jan 4, 2024

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale Stale label Jan 4, 2024
@coreybutler coreybutler removed the Stale Stale label Jan 4, 2024
Copy link

github-actions bot commented Feb 4, 2024

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale Stale label Feb 4, 2024
@talynone talynone mentioned this pull request Jun 27, 2024
1 task
@talynone
Copy link

talynone commented Jul 28, 2024

I built/tested this version, there's an error in the version check logic preventing the install of the latest ARM64 (22.5.1) version:

As currently written, for the latest version (22.5.1), it passes the main version check, but then fails the minor version check since the value of minor is 5 which is lower than 9.

func IsNodeArm64bitAvailable(v string) bool {
	if v == "latest" {
		return true
	}

	// Anything below version 8 doesn't have a 64 bit version
	vers := strings.Fields(strings.Replace(v, ".", " ", -1))
	main, _ := strconv.ParseInt(vers[0], 0, 0)
	minor, _ := strconv.ParseInt(vers[1], 0, 0)
	fmt.Println("main "+ strconv.FormatInt(main,10) + " minor "+strconv.FormatInt(minor,10))
	if main < 19 {
		return false
	}
	if minor < 9{
		return false
	}
	
	// TODO: fixme. Assume a 64 bit version exists
	return true
}

@github-actions github-actions bot removed the Stale Stale label Jul 29, 2024
Copy link

github-actions bot commented Sep 1, 2024

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale Stale label Sep 1, 2024
@coreybutler coreybutler removed the Stale Stale label Sep 1, 2024
@coreybutler
Copy link
Owner

Update - I'm working with Microsoft to get a new code signing certificate. Once that is done, I'll start merging PRs (including this one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants