fix: wrap error messages in fmt.Errorf #438
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use %w instead of %v when nesting error messages so they can be properly unwrapped by upstream callers.
I've run into a problem where I'm unable to use errors.Is() in my tooling to help properly respond to errors coming out of oidc. The primary use case is checking for context.Canceled, but I'm sure there are others.
Note: I believe %w was introduced in Go version 1.13, so this change isn't friendly to users who use a 5 year old Go version but keep their packages up to date. In any case, it's possible this package already requires a higher Go version than that.