Import SElinux module #477 #486

yasminvalim · 2023-08-28T17:55:27Z

Import SElinux module

We want to add sugar to butane which will allow users import costum SElinux module.

Related Issues

travier · 2023-08-31T10:13:49Z

Just a small note for your name in the Git config:

From: YASMIN VALIM <[email protected]>

You probably want Yasmin Valim <[email protected]> instead.

You'll have to modify it in you ~/.gitconfig and then "reset" the author for all your commits here with git rebase or git commit --amend.

yasminvalim · 2023-09-15T16:18:29Z

I'm now trying to test manually, and while reading the documentation, I had a question:
How can I be sure that my code is running locally?

I understand that I can build it with custom files that I created and it will be translated from BU to Ignition.
But I'm not sure how can I run the code I made instead of the butane version I installed and the latest image.

I think I am missing something.

prestist · 2023-09-15T17:19:02Z

I'm now trying to test manually, and while reading the documentation, I had a question: How can I be sure that my code is running locally?

I understand that I can build it with custom files that I created and it will be translated from BU to Ignition. But I'm not sure how can I run the code I made instead of the butane version I installed and the latest image.

Noooo worries there are a lot of layers here.

So, to test it locally we have to exercise your code which lives in butane, then we want to test that our expectation of what is required for the system to effectively implement the sugar is correct which is done by exercising existing code in ignition through first booting a fcos image.

The simplest step is directly exercising your code by creating a butane config which references the sugar you added, and using your locally built butane to create an .ign file.

build your butane, and then ./butane.bin --pretty --strict example.bu > example.ign
Note you will want a way to get into your running fcos image so you can verify things in the OS after its running.
you can read a guide about auto login here.
- so to summarize your .bu will be the bu yaml in the example + your sugar.

Now to exercise your assumptions for enabling a semodule you would then need to first boot a fcos vm with your ignition config. The simpliest way to do this is by using cosa

You can either download a qcow image from here or build your own using cosa int, fetch, build
Then you can pass your ign file you built earlier using a command like so $ cosa kola qemuexec --ignition ./ignition.json --ignition-direct --qemu-image ./yourImage.qcow2
If the ign config is understood and functional, you should be greeted by the console (with auto login) then you can do your probing of the os to see if the selinux module is enabled (as your sugar indicates)

travier · 2023-09-18T09:20:10Z

You can find an small example SELinux module (CIL) in coreos/fedora-coreos-tracker#1447 (comment)

yasminvalim · 2023-10-05T21:36:00Z

Hey there,

I'm sharing my current approach for tackling this issue. I did have a few other ideas, but this one seems to be the most on point. I'm planning to commit the code I've been working on in the next few days, even though it might not be 100% ready, and it could potentially break my CI setup.

Here's the plan I've got in mind. If you've got any cool ideas or questions that could help me sharpen things up, please don't hold back.

Fields with content of the SElinux file and the file path
Create a filesystem (file: translate.go) (do I need it?)
Create the file with that path and the content (file: translate.go)
Execute the command “semodule -i” + path (file: translate.go)
Translate butane to ignition (file: translate.go)
Validate some rules in validate.go:
- If there is a path, the content is required
- If there is a content, the path is required
- Any more rules required?
Unit tests

This current approach would look like that in a butane file:

variant: fcos
version: 1.6.0-experimental
selinux_module:
  - contents:
      - |
        # setenforce 1
        # cat permissive-keyutils.cil
        (type keyutils_request_t)
        (typepermissive keyutils_request_t)
        # semodule -i permissive-keyutils.cil
  - path: /path/to/selinux/custom/file

Your input would be awesome and thanks for your attention.

travier · 2023-10-10T15:04:24Z

The example Butane config should likely only include the content of the SELinux module:

variant: fcos
version: 1.6.0-experimental
selinux:
  module:
    - name: "permissive-keyutils"
    - contents: |
        (type keyutils_request_t)
        (typepermissive keyutils_request_t)

Then Butane would generate an Ignition config that:

writes the content of this module to a file in /etc/selinux/custom-modules/<module-name.cil> (not sure where exactly would be best)
adds a systemd unit that loads this module on first boot using semodule -i ....

prestist · 2023-10-10T15:48:15Z

Your approach is sound. It might make sense to create tests before making the functions. In this case in particular could be well suited for TDD, and just create a test like TestTranslateBootDevice which would fail until you create the translate code to build the sugar.

Since you have a sound understanding of the input and the expected output. And as long as your spec changes are there you should be able to run the test with no compile errors.

config/fcos/v1_6_exp/translate.go

yasminvalim · 2023-11-10T16:12:04Z

Hey folks, I am still having problem with unit tests. Currently, I am having this error and those are the logs.
This error applies to each line in translations.

--- FAIL: TestTranslateSelinux (0.00s)
    --- FAIL: TestTranslateSelinux/translate_0 (0.00s)
        /home/ydesouza/butane/config/fcos/v1_6_exp/test.go:45: 
            	Error Trace:	/home/ydesouza/butane/base/util/test.go:45
            	            				/home/ydesouza/butane/config/fcos/v1_6_exp/translate_test.go:1717
            	Error:      	Not equal: 
            	            	expected: translate.Translation{From:path.ContextPath{Path:[]interface {}{"selinux", "module", 0}, Tag:"yaml"}, To:path.ContextPath{Path:[]interface {}{"storage"}, Tag:"json"}}
            	            	actual  : translate.Translation{From:path.ContextPath{Path:[]interface {}{"selinux", "module"}, Tag:"yaml"}, To:path.ContextPath{Path:[]interface {}{"storage"}, Tag:"json"}}
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -2,6 +2,5 @@
            	            	  From: (path.ContextPath) {
            	            	-  Path: ([]interface {}) (len=3) {
            	            	+  Path: ([]interface {}) (len=2) {
            	            	    (string) (len=7) "selinux",
            	            	-   (string) (len=6) "module",
            	            	-   (int) 0
            	            	+   (string) (len=6) "module"
            	            	   },
            	Test:       	TestTranslateSelinux/translate_0
            	Messages:   	non-identity translation with unexpected From

What I am missing here?
Thanks! 😸

jlebon

I'm not an SME on this codebase and don't have the cycles to be one, unfortunately. :( I did a semi-shallow review of what I could piece together.

config/common/errors.go

config/fcos/v1_6_exp/translate.go

config/fcos/v1_6_exp/translate_test.go

config/fcos/v1_6_exp/translate.go

config/fcos/v1_6_exp/validate.go

yasminvalim · 2023-11-23T12:40:03Z

After spending time debugging, I'm still encountering similar errors to those I had before, despite making various changes. If anyone has any ideas about what might be causing this, I would appreciate. Thanks!

--- FAIL: TestTranslateSelinux (0.00s)
    --- FAIL: TestTranslateSelinux/translate_0 (0.00s)
        /home/ydesouza/butane/config/fcos/v1_6_exp/test.go:47: missing non-identity translation $.selinux.module → $.storage
        /home/ydesouza/butane/config/fcos/v1_6_exp/test.go:47: missing non-identity translation $.selinux.module.0 → $.systemd.units.0.dropins
        /home/ydesouza/butane/config/fcos/v1_6_exp/test.go:47: missing non-identity translation $.selinux.module.0 → $.systemd.units.0.dropins.0
        /home/ydesouza/butane/config/fcos/v1_6_exp/test.go:47: missing non-identity translation $.selinux.module.0 → $.storage.files
        /home/ydesouza/butane/config/fcos/v1_6_exp/test.go:47: missing non-identity translation $.selinux.module.0 → $.storage.files.0
        /home/ydesouza/butane/config/fcos/v1_6_exp/test.go:47: missing non-identity translation $.selinux.module.0 → $.storage.files.0.path
        /home/ydesouza/butane/config/fcos/v1_6_exp/test.go:47: missing non-identity translation $.selinux.module.0 → $.storage.files.0.append
        /home/ydesouza/butane/config/fcos/v1_6_exp/test.go:47: missing non-identity translation $.selinux.module.0 → $.storage.files.0.append.0
        /home/ydesouza/butane/config/fcos/v1_6_exp/test.go:47: missing non-identity translation $.selinux.module.0 → $.storage.files.0.append.0.source
        /home/ydesouza/butane/config/fcos/v1_6_exp/test.go:55: 
            	Error Trace:	/home/ydesouza/butane/base/util/test.go:55
            	            				/home/ydesouza/butane/config/fcos/v1_6_exp/translate_test.go:1726
            	Error:      	Not equal: 
            	            	expected: []interface {}{"selinux", "module", 0}
            	            	actual  : []interface {}{"systemd", "units", 0, "contents"}
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -1,5 +1,6 @@
            	            	-([]interface {}) (len=3) {
            	            	- (string) (len=7) "selinux",
            	            	- (string) (len=6) "module",
            	            	- (int) 0
            	            	+([]interface {}) (len=4) {
            	            	+ (string) (len=7) "systemd",
            	            	+ (string) (len=5) "units",
            	            	+ (int) 0,
            	            	+ (string) (len=8) "contents"
            	            	 }
            	Test:       	TestTranslateSelinux/translate_0
            	Messages:   	translation is not identity
        /home/ydesouza/butane/config/fcos/v1_6_exp/test.go:55: 
            	Error Trace:	/home/ydesouza/butane/base/util/test.go:55
            	            				/home/ydesouza/butane/config/fcos/v1_6_exp/translate_test.go:1726
            	Error:      	Not equal: 
            	            	expected: []interface {}{"selinux", "module", 0}
            	            	actual  : []interface {}{"systemd", "units", 0, "enabled"}
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -1,5 +1,6 @@
            	            	-([]interface {}) (len=3) {
            	            	- (string) (len=7) "selinux",
            	            	- (string) (len=6) "module",
            	            	- (int) 0
            	            	+([]interface {}) (len=4) {
            	            	+ (string) (len=7) "systemd",
            	            	+ (string) (len=5) "units",
            	            	+ (int) 0,
            	            	+ (string) (len=7) "enabled"
            	            	 }
            	Test:       	TestTranslateSelinux/translate_0
            	Messages:   	translation is not identity
        /home/ydesouza/butane/config/fcos/v1_6_exp/translate_test.go:1727: 
            	Error Trace:	/home/ydesouza/butane/config/fcos/v1_6_exp/translate_test.go:1727
            	Error:      	Received unexpected error:
            	            	Missing paths in TranslationSet:
            	            	$.storage.files.0.path
            	            	$.storage.files.0.append.0.compression
            	            	$.storage.files.0.append.0.source
            	            	$.storage.files.0.append.0
            	            	$.storage.files.0.append
            	            	$.storage.files.0
            	            	$.storage.files
            	            	$.storage
            	            	$.systemd.units
            	            	$.systemd
            	Test:       	TestTranslateSelinux/translate_0
            	Messages:   	incomplete TranslationSet coverage
FAIL
FAIL	github.com/coreos/butane/config/fcos/v1_6_exp	0.003s

yasminvalim · 2023-12-14T15:01:10Z

I've made few changes based on the review and debugged the code. However, I'm still uncertain about what's causing the issue in either the code or the test itself. Below is the current error.

Running tool: /usr/bin/go test -timeout 30s -run ^TestTranslateSelinux$ github.com/coreos/butane/config/fcos/v1_6_exp

--- FAIL: TestTranslateSelinux (0.00s)
    --- FAIL: TestTranslateSelinux/translate_0 (0.00s)
        /home/ydesouza/butane/config/fcos/v1_6_exp/test.go:47: missing non-identity translation $.selinux.module → $.storage
        /home/ydesouza/butane/config/fcos/v1_6_exp/test.go:47: missing non-identity translation $.selinux.module.0 → $.storage.files
        /home/ydesouza/butane/config/fcos/v1_6_exp/test.go:47: missing non-identity translation $.selinux.module.0 → $.storage.files.0
        /home/ydesouza/butane/config/fcos/v1_6_exp/test.go:47: missing non-identity translation $.selinux.module.0 → $.storage.files.0.path
        /home/ydesouza/butane/config/fcos/v1_6_exp/test.go:47: missing non-identity translation $.selinux.module.0 → $.storage.files.0.append
        /home/ydesouza/butane/config/fcos/v1_6_exp/test.go:47: missing non-identity translation $.selinux.module.0 → $.storage.files.0.append.0
        /home/ydesouza/butane/config/fcos/v1_6_exp/test.go:47: missing non-identity translation $.selinux.module.0 → $.storage.files.0.append.0.source
        /home/ydesouza/butane/config/fcos/v1_6_exp/test.go:47: missing non-identity translation $.selinux.module.0 → $.storage.files.0.append.0.compression
        /home/ydesouza/butane/config/fcos/v1_6_exp/translate_test.go:1737: 
            	Error Trace:	/home/ydesouza/butane/config/fcos/v1_6_exp/translate_test.go:1737
            	Error:      	Received unexpected error:
            	            	Missing paths in TranslationSet:
            	            	$.storage.files.0.path
            	            	$.storage.files.0.append.0.compression
            	            	$.storage.files.0.append.0.source
            	            	$.storage.files.0.append.0
            	            	$.storage.files.0.append
            	            	$.storage.files.0
            	            	$.storage.files
            	            	$.storage
            	            	$.systemd.units
            	            	$.systemd
            	Test:       	TestTranslateSelinux/translate_0
            	Messages:   	incomplete TranslationSet coverage
FAIL
FAIL	github.com/coreos/butane/config/fcos/v1_6_exp	0.003s
FAIL

Please share any insights if you have them. 😸

config/fcos/v1_6_exp/schema.go

prestist

We did a debug session on this, and finally got to a workable point, but we remain puzzled on these two things @jlebon

prestist · 2023-12-19T22:07:29Z

config/fcos/v1_6_exp/translate.go

+				"WantedBy=multi-user.target\n"),
+		Enabled: util.BoolToPtr(true),
+	})
+	ts.AddFromCommonSource(yamlPath, path.New("json", "systemd"), rendered.Systemd)


So while this certainly passes the validate, I am having difficulty understanding why this should not be

ts.AddFromCommonSource(yamlPath, path.New("json", "systemd","units",len(rendred.systemd.units)), rendered.Systemd.units)

And I think this is correct too.

prestist · 2023-12-19T22:08:02Z

config/fcos/v1_6_exp/translate.go

+			},
+		},
+	})
+	ts.AddFromCommonSource(yamlPath, path.New("json", "storage"), rendered.Storage)


So while this certainly passes the validate, I am having difficulty understanding why this should not be

ts.AddFromCommonSource(yamlPath, path.New("json", "storage","files",len(rendred.storage.files)), rendered.storage.files)

I think I understand this better now.

So I do think this is correct. It's saying that everything under and including the .storage key is associated with that module (after adding the index like I mentioned above, it'd be .selinux.module.0 -> .storage and -> .storage.files and so on). Essentially, we're not just adding a file and a unit because of this module, we have to add all the keys leading up to it. All keys in the output need a source translation associated, so e.g. .storage needs to be associated to something on the YAML side.

prestist · 2024-01-04T18:21:33Z

@yasminvalim the go 1.21 test should be fixed by #505.

steps to update branch

assuming origin is your fork and upstream is

git fetch upstream
git merge upstream/main 
git push -f

yasminvalim · 2024-01-04T19:29:27Z

@yasminvalim the go 1.21 test should be fixed by #505.

steps to update branch

Thanks, I updated my branch and I will squash to have just one commit. 😸

prestist · 2024-01-09T18:24:23Z

@yasminvalim the go 1.21 test should be fixed by #505.
steps to update branch
assuming origin is your fork and upstream is

Sorry I led you astray, the merge commit is nooooo good, the best thing to do is likely to undo your merge and just rebase

git revert -m 1 a419de4
git fetch upstream
git rebase upstream/main

that way your fast-forwarded rather then merged into.

yasminvalim · 2024-01-09T20:03:09Z

@yasminvalim the go 1.21 test should be fixed by #505.
steps to update branch
assuming origin is your fork and upstream is

Sorry I led you astray, the merge commit is nooooo good, the best thing to do is likely to undo your merge and just rebase

git revert -m 1 a419de4 git fetch upstream git rebase upstream/main

that way your fast-forwarded rather then merged into.

I think it's fine now, but not entirely sure because it's showing all the files updated in the old merge. Can you take a look, please?

Also, can I use rebase as a pattern when I need to update a branch?

prestist · 2024-01-11T14:31:35Z

@yasminvalim I am a bit confused because this 36f71f1 should not be a thing. after reverting your merge it should have put you in a place with only your other commit.

Once you revert the merge you can update your branch with the rebase pattern instead.

jlebon · 2024-01-12T22:08:49Z

config/fcos/v1_6_exp/schema.go

+
+type Module struct {
+	Name    string `yaml:"name"`
+	Content string `yaml:"content"`


I think probably this hsould be a Resource instead of a string. E.g. I can imagine wanting to keep this in a separate cil file and then using local.

I did it, but I'm not sure if it's good enough.
I created a type 'resource' in v1_6_exp/schema as in the other versions to include it as a type for 'contents'.

The tests are working even with this change, so I think it's okay.

jlebon · 2024-01-13T01:45:22Z

config/fcos/v1_6_exp/schema.go

@@ -50,3 +51,12 @@ type GrubUser struct {
 	Name         string  `yaml:"name"`
 	PasswordHash *string `yaml:"password_hash"`
 }
+
+type Selinux struct {
+	Module []Module `yaml:"module"`


I think this should be

Suggested change

Module []Module `yaml:"module"`

Modules []Module `yaml:"modules"`

List keys are pluralized (disks, filesystems, files, etc...).

Nice! I changed it and also altered content to plural since the other examples are also using plural.

jlebon · 2024-01-13T02:14:33Z

config/fcos/v1_6_exp/translate.go

+	var r report.Report
+
+	for _, module := range c.Selinux.Module {
+		rendered = processModule(rendered, module, options, ts, r, path.New("yaml", "selinux", "module"))


We should add the index to the path here so that e.g. module 2 is associated with the right output files and systemd units.

Added the index path in the implementation and in the 'From Path' in test files. 👍

jlebon · 2024-01-13T02:18:25Z

config/fcos/v1_6_exp/translate.go

+			},
+		},
+	})
+	ts.AddFromCommonSource(yamlPath, path.New("json", "storage"), rendered.Storage)


I think I understand this better now.

So I do think this is correct. It's saying that everything under and including the .storage key is associated with that module (after adding the index like I mentioned above, it'd be .selinux.module.0 -> .storage and -> .storage.files and so on). Essentially, we're not just adding a file and a unit because of this module, we have to add all the keys leading up to it. All keys in the output need a source translation associated, so e.g. .storage needs to be associated to something on the YAML side.

jlebon · 2024-01-13T02:18:44Z

config/fcos/v1_6_exp/translate.go

+				"WantedBy=multi-user.target\n"),
+		Enabled: util.BoolToPtr(true),
+	})
+	ts.AddFromCommonSource(yamlPath, path.New("json", "systemd"), rendered.Systemd)


And I think this is correct too.

jlebon · 2024-01-13T02:19:08Z

config/fcos/v1_6_exp/translate_test.go

+		{From: path.New("yaml", "selinux", "module"), To: path.New("json", "storage")},
+		{From: path.New("yaml", "selinux", "module"), To: path.New("json", "storage", "files")},
+		{From: path.New("yaml", "selinux", "module"), To: path.New("json", "storage", "files", 0)},
+		{From: path.New("yaml", "selinux", "module"), To: path.New("json", "storage", "files", 0, "path")},
+		{From: path.New("yaml", "selinux", "module"), To: path.New("json", "storage", "files", 0, "append")},
+		{From: path.New("yaml", "selinux", "module"), To: path.New("json", "storage", "files", 0, "append", 0)},
+		{From: path.New("yaml", "selinux", "module"), To: path.New("json", "storage", "files", 0, "append", 0, "source")},
+		{From: path.New("yaml", "selinux", "module"), To: path.New("json", "storage", "files", 0, "append", 0, "compression")},
+		{From: path.New("yaml", "selinux", "module"), To: path.New("json", "systemd", "units", 0, "name")},
+		{From: path.New("yaml", "selinux", "module"), To: path.New("json", "systemd", "units", 0, "contents")},
+		{From: path.New("yaml", "selinux", "module"), To: path.New("json", "systemd", "units", 0, "enabled")},
+		{From: path.New("yaml", "selinux", "module"), To: path.New("json", "systemd", "units", 0)},
+		{From: path.New("yaml", "selinux", "module"), To: path.New("json", "systemd", "units")},
+		{From: path.New("yaml", "selinux", "module"), To: path.New("json", "systemd")},


With the added index, you'd add 0 to all the From paths here.

jlebon · 2024-01-13T02:23:26Z

config/fcos/v1_6_exp/translate.go

+		Name: module.Name + ".conf",
+		Contents: util.StrToPtr(
+			"[Unit]\n" +
+				"Description=Import SELinux module\n" +


This description should be templated.

I saw in another file how it's done and managed to reproduce. Thank you for letting me know 🐱

jlebon · 2024-01-13T02:23:53Z

config/fcos/v1_6_exp/translate.go

+
+	rendered.Systemd.Units = append(rendered.Systemd.Units, types.Unit{
+		Name: module.Name + ".conf",
+		Contents: util.StrToPtr(


I would add a comment here (in the generated systemd unit) like:

# Generated by Butane

Done, I've added the comment. Thanks. 😸

jlebon · 2024-01-13T02:27:16Z

config/fcos/v1_6_exp/validate.go

+	if m.Name == "" && m.Content == "" {
+		r.AddOnError(c.Append("name"), common.ErrSelinuxContentNotSpecified)
+		r.AddOnError(c.Append("content"), common.ErrSelinuxContentNotSpecified)
+	} else {


I don't think we need this.

I removed both this implementation and test.

Thanks for your review :)

config/fcos/v1_6_exp/validate_test.go

It depends on fcos 1.6.0-experimental See: coreos#484 See: coreos#514 Fixes: coreos#517

yasminvalim self-assigned this Aug 28, 2023

yasminvalim marked this pull request as draft August 28, 2023 17:55

yasminvalim linked an issue Aug 28, 2023 that may be closed by this pull request

Import SElinux module #477

Open

yasminvalim force-pushed the 477-import-selinux branch 2 times, most recently from 6e31b30 to 586a029 Compare August 30, 2023 14:02

yasminvalim force-pushed the 477-import-selinux branch from ccb3d49 to 946531f Compare August 31, 2023 20:42

yasminvalim closed this Aug 31, 2023

yasminvalim force-pushed the 477-import-selinux branch from 946531f to 0a1b18e Compare August 31, 2023 20:43

yasminvalim reopened this Aug 31, 2023

yasminvalim force-pushed the 477-import-selinux branch from 7c08dc7 to 75142d6 Compare September 8, 2023 20:49

yasminvalim force-pushed the 477-import-selinux branch from 75142d6 to 6fc2da9 Compare October 2, 2023 13:32

prestist reviewed Nov 6, 2023

View reviewed changes

config/fcos/v1_6_exp/translate.go Outdated Show resolved Hide resolved

config/fcos/v1_6_exp/translate.go Outdated Show resolved Hide resolved

config/fcos/v1_6_exp/translate.go Outdated Show resolved Hide resolved

prestist reviewed Nov 7, 2023

View reviewed changes

yasminvalim force-pushed the 477-import-selinux branch 2 times, most recently from 5b83d3c to 48ed3ac Compare November 10, 2023 16:02

yasminvalim force-pushed the 477-import-selinux branch from 48ed3ac to 310a1f1 Compare November 14, 2023 18:56

jlebon reviewed Nov 14, 2023

View reviewed changes

yasminvalim force-pushed the 477-import-selinux branch 2 times, most recently from 30a7dfa to 87011dc Compare November 20, 2023 19:27

yasminvalim force-pushed the 477-import-selinux branch 2 times, most recently from a47e0b0 to 8149574 Compare December 11, 2023 15:14

yasminvalim force-pushed the 477-import-selinux branch from 8149574 to 3940153 Compare December 14, 2023 14:23

jlebon reviewed Dec 14, 2023

View reviewed changes

config/fcos/v1_6_exp/schema.go Outdated Show resolved Hide resolved

config/fcos/v1_6_exp/schema.go Outdated Show resolved Hide resolved

yasminvalim force-pushed the 477-import-selinux branch 3 times, most recently from 1b6bae2 to 6f9bf5f Compare December 19, 2023 22:04

prestist reviewed Dec 19, 2023

View reviewed changes

yasminvalim force-pushed the 477-import-selinux branch from a419de4 to 36f71f1 Compare January 9, 2024 19:51

yasminvalim force-pushed the 477-import-selinux branch from 36f71f1 to 7960a5b Compare January 12, 2024 13:08

jlebon reviewed Jan 13, 2024

View reviewed changes

yasminvalim added 3 commits February 19, 2024 19:17

fcos/v1_6_exp: Add new sugar for Selinux Modules.

3cf4dd3

fcos/v1_6_exp: Add code reviews insights

363a23e

fcos/v1_6_exp: Remove validations

47441f1

yasminvalim force-pushed the 477-import-selinux branch from 5086831 to 47441f1 Compare February 19, 2024 22:17

docs: Move s390x boot_devices sugar to ocp 4.16.0-experimental

ad0fd81

It depends on fcos 1.6.0-experimental See: coreos#484 See: coreos#514 Fixes: coreos#517

	Module []Module `yaml:"module"`
	Modules []Module `yaml:"modules"`

Import SElinux module #477 #486

Are you sure you want to change the base?

Import SElinux module #477 #486

Conversation

yasminvalim commented Aug 28, 2023

Import SElinux module

Related Issues

travier commented Aug 31, 2023

yasminvalim commented Sep 15, 2023

prestist commented Sep 15, 2023

travier commented Sep 18, 2023

yasminvalim commented Oct 5, 2023 • edited Loading

travier commented Oct 10, 2023 • edited Loading

prestist commented Oct 10, 2023

yasminvalim commented Nov 10, 2023

jlebon left a comment

Choose a reason for hiding this comment

yasminvalim commented Nov 23, 2023

yasminvalim commented Dec 14, 2023

prestist left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prestist commented Jan 4, 2024

yasminvalim commented Jan 4, 2024

prestist commented Jan 9, 2024 • edited Loading

yasminvalim commented Jan 9, 2024

prestist commented Jan 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yasminvalim commented Oct 5, 2023 •

edited

Loading

travier commented Oct 10, 2023 •

edited

Loading

prestist commented Jan 9, 2024 •

edited

Loading