Add $OPTION directive and "fallthrough" option
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisohaver
requested changes
Mar 10, 2023
fuhry
force-pushed
the
fallthrough-support
branch
from
5c172cf
to
9fd9193
Compare
|
@chrisohaver I've addressed all comments, can you re-review? Thanks! |
fuhry
force-pushed
the
fallthrough-support
branch
2 times, most recently
from
89a9aa8
to
cb0f77a
Compare
Add the `$OPTION` directive to allow configuring the plugin. Implement an option, "fallthrough" which causes the plugin to continue to the next plugin in the chain when there is no match, instead of always returning NXDOMAIN. Signed-Off-By: Dan Fuhry <[email protected]>
fuhry
force-pushed
the
fallthrough-support
branch
from
cb0f77a
to
bd8474d
Compare
|
Pushes since my most recent comment are the addition of tests for fall-through functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
$OPTIONdirective to allow configuring the plugin.Implement an option, "fallthrough" which causes the plugin to continue to the next plugin in the chain when there is no match, instead of always returning NXDOMAIN.