bump: anchor v0.22.0 #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programs/multisig/src/lib.rs
Outdated
| @@ -236,6 +236,7 @@ pub struct ExecuteTransaction<'info> { | |||
| seeds = [multisig.key().as_ref()], | |||
| bump = multisig.nonce, | |||
| )] | |||
| /// CHECK: is_signer will be enabled when it actually gets executed | |||
There was a problem hiding this comment.
Let's change this to /// CHECK: multisig_signer is a PDA program signer. Data is never read or written to. and also move this comment above the attribute, assuming the lint doesn't complain.
There was a problem hiding this comment.
Hi, thanks for looking. @armaniferrante
I'm not sure what move this comment above the attribute means, I tried to put this above the struct declaration, and over the #[derive(Accounts)] attribute but got the error that it wants the /// CHECK:
There was a problem hiding this comment.
I meant above the #[account(...)] attribute.
There was a problem hiding this comment.
got it! done in 77bf80a (squashed commit for clarity)
fanatid
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.