-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thomas Dillard - Frontend Challenge #83
Open
indifferentghost
wants to merge
15
commits into
contra:main
Choose a base branch
from
indifferentghost:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added this .gitignore as a temp fix, when I open sub directories and their parent repositories the `.yarn/cache` was still populating. This may be a configuration issue with the `.gitignore`.
Updated example includes adding jest-environment-dom. Added testing-library for its ease-of-use and prevalence in the industry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a responsive and accessible modal.
The component meets the following requirements:
Although the modal currently lacks multi-modal environment support, implementing this feature could start by abstracting the state of the modals to a common parent, similar to how the React docs example manages multiple refs. This could include adding a context and state handler, or using popular libraries like
jotai
or other atomic state management systems.While the modal component includes basic aria and role attributes on most required elements, further improvements may include:
event.relatedTarget
may hold the secretsModal.Title
component that satisfiesaria-labeledBy
Further improvements might include:
Here's a loom video that provides a TL;DR: https://www.loom.com/share/1f441bf6a35e403e940cab1645be2aba
I'm excited to hear more!