Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): disable ExpandProps while we investigate a bug caused by it #1836

Merged
merged 1 commit into from
Jan 31, 2022
Merged

fix(core): disable ExpandProps while we investigate a bug caused by it #1836

merged 1 commit into from
Jan 31, 2022

Conversation

massao
Copy link
Contributor

@massao massao commented Jan 28, 2022

Purpose of PR

Disable ExpandProps on types, to avoid build errors while we investigate a proper solution for:
#1834

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

@massao massao requested review from Lelith, m10l, mshaaban0 and a team as code owners January 28, 2022 16:39
@massao massao requested a review from thebesson January 28, 2022 16:39
@vercel
Copy link

vercel bot commented Jan 28, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/contentful-apps/forma-36/94wdZuozRkzY5XrrtESqYxPswdcS
✅ Preview: https://forma-36-git-fix-remove-expand-props-contentful-apps.vercel.app

@massao massao merged commit 35e30ce into master Jan 31, 2022
@massao massao deleted the fix/remove-expand-props branch January 31, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denkristoffer denkristoffer denkristoffer approved these changes

@bgutsol bgutsol Awaiting requested review from bgutsol

@Lelith Lelith Awaiting requested review from Lelith

@m10l m10l Awaiting requested review from m10l

@mshaaban0 mshaaban0 Awaiting requested review from mshaaban0

@thebesson thebesson Awaiting requested review from thebesson thebesson was automatically assigned from contentful/team-isotopes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@massao @denkristoffer