Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove exit file from persistent storage #24399

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove exit file from persistent storage #24399

wants to merge 1 commit into from

Conversation

luckyevildev
Copy link

@luckyevildev luckyevildev commented Oct 29, 2024 •
edited
Loading

Does this PR introduce a user-facing change?

None

[NO NEW TESTS NEEDED]

This MR changes this behaviour - podman will exit-file from persist-dir after calling conmon.

It helps avoid this situation in case of systemd restart-always policy

image

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Oct 29, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: luckyevildev
Once this PR has been reviewed and has the lgtm label, please assign baude for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@luckyevildev luckyevildev force-pushed the remove-persist-dir branch 3 times, most recently from 662dfc2 to ca6fb22 Compare October 29, 2024 06:40
@packit-as-a-service Packit-as-a-Service
Copy link

Cockpit tests failed for commit ed4120a. @martinpitt, @jelly, @mvollmer please check.

@packit-as-a-service Packit-as-a-Service
Copy link

Cockpit tests failed for commit c70beb2. @martinpitt, @jelly, @mvollmer please check.

@packit-as-a-service Packit-as-a-Service
Copy link

Cockpit tests failed for commit ed4120a. @martinpitt, @jelly, @mvollmer please check.

@packit-as-a-service Packit-as-a-Service
Copy link

Cockpit tests failed for commit c70beb2. @martinpitt, @jelly, @mvollmer please check.

@packit-as-a-service Packit-as-a-Service
Copy link

Cockpit tests failed for commit 662dfc2. @martinpitt, @jelly, @mvollmer please check.

@packit-as-a-service Packit-as-a-Service
Copy link

Cockpit tests failed for commit ca6fb22. @martinpitt, @jelly, @mvollmer please check.

@martinpitt
Copy link
Contributor

FTR, I'll ignore the user pod regression in the cockpit tests, as long as podman's own tests are still red. (Not sure why packit just sent a whole truckload of notifications -- rapid series of force-pushes?)

@luckyevildev luckyevildev force-pushed the remove-persist-dir branch 2 times, most recently from 221338f to 5a193c4 Compare October 29, 2024 08:09
@packit-as-a-service Packit-as-a-Service
Copy link

Cockpit tests failed for commit 221338f. @martinpitt, @jelly, @mvollmer please check.

@packit-as-a-service Packit-as-a-Service
Copy link

Cockpit tests failed for commit 5a193c4. @martinpitt, @jelly, @mvollmer please check.

@packit-as-a-service Packit-as-a-Service
Copy link

Cockpit tests failed for commit 5fcd684. @martinpitt, @jelly, @mvollmer please check.

@luckyevildev luckyevildev force-pushed the remove-persist-dir branch 4 times, most recently from 306df59 to 3c2141b Compare October 30, 2024 10:19
@packit-as-a-service Packit-as-a-Service
Copy link

Cockpit tests failed for commit 0e54c3a. @martinpitt, @jelly, @mvollmer please check.

@packit-as-a-service Packit-as-a-Service
Copy link

Cockpit tests failed for commit 36d234d. @martinpitt, @jelly, @mvollmer please check.

@packit-as-a-service Packit-as-a-Service
Copy link

Cockpit tests failed for commit 98fe9e8. @martinpitt, @jelly, @mvollmer please check.

@packit-as-a-service Packit-as-a-Service
Copy link

Cockpit tests failed for commit 306df59. @martinpitt, @jelly, @mvollmer please check.

@packit-as-a-service Packit-as-a-Service
Copy link

Cockpit tests failed for commit 3c2141b. @martinpitt, @jelly, @mvollmer please check.

@luckyevildev luckyevildev changed the title WIP Remove exit and oom from persist dir WIP Remove exit file from persistent storage Oct 30, 2024
@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@luckyevildev luckyevildev force-pushed the remove-persist-dir branch 2 times, most recently from c739c85 to e881b12 Compare October 30, 2024 11:45
@luckyevildev luckyevildev changed the title WIP Remove exit file from persistent storage Remove exit file from persistent storage Oct 30, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2024
@luckyevildev
Copy link
Author

@martinpitt sorry for all this mess in thread but it's done i think, please take a look.

No tests needed 🤔

@luckyevildev
Copy link
Author

/release-note-none

@openshift-ci openshift-ci bot added release-note-none and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luckyevildev @martinpitt