Skip to content

Commit

Permalink
Test that CI successfully fails
Browse files Browse the repository at this point in the history
I think a good pattern is to keep an open (draft) pull request
that *should* fail CI, and verify that it actually does.

It's surprisingly easily to e.g. have CI not actually test the
code.  In this case we have our "reverse dependency testing"
which patches the crate to use the local code, and that could
easily not work.
  • Loading branch information
cgwalters committed Nov 23, 2022
1 parent 4c039d4 commit 19a827f
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/imageproxy.rs
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,9 @@ impl ImageProxy {
if fd.is_some() {
return Err(anyhow!("Unexpected fd in finish_pipe reply"));
}
if true {
anyhow::bail!("synthetic CI failure");
}
Ok(r)
}

Expand Down

0 comments on commit 19a827f

Please sign in to comment.