Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCI-archive multi-manifest support POC #1178

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

OCI-archive multi-manifest support POC #1178

wants to merge 11 commits into from

Commits on Mar 3, 2022

  1. Add multi oci manifest support to load and save 

    Signed-off-by: Urvashi Mohnani <[email protected]>
    @umohnani8
    umohnani8 committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    c3d50f6 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2022

  1. vendor c/image 

    Signed-off-by: Urvashi Mohnani <[email protected]>
    @umohnani8
    umohnani8 committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    e39b9dc View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. Merge branch 'multi' of https://github.com/umohnani8/common into mult… 

    …i-poc

Signed-off-by: Miloslav Trmač <[email protected]>
    @mtrmac
    mtrmac committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    556a5fa View commit details
    Browse the repository at this point in the history

  2. DO NOT MERGE: Vendor containers/image#1677 

    Signed-off-by: Miloslav Trmač <[email protected]>
    @mtrmac
    mtrmac committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    5eb7277 View commit details
    Browse the repository at this point in the history

  3. Simplify API of loadMultiImageOCIArchive 

    It can only accept a path, so don't round-trip through an ImageReference.

(Alternatively, this could use a similar heuristic to loadMultiImageDockerArchive,
stat()in the path. But even in that case it should first make a decision and _then_
potentially create a reference.)

Signed-off-by: Miloslav Trmač <[email protected]>
    @mtrmac
    mtrmac committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    5b9deff View commit details
    Browse the repository at this point in the history

  4. Update comments 

    Signed-off-by: Miloslav Trmač <[email protected]>
    @mtrmac
    mtrmac committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    3ef1a63 View commit details
    Browse the repository at this point in the history

  5. Rewrite the OCI load/pull logic 

    Model it more directly on the docker-archive logic.

Pulls specify a single ref, and use all parts of that to choose a single image.
Loads load all of the archive.

Signed-off-by: Miloslav Trmač <[email protected]>
    @mtrmac
    mtrmac committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    7fed136 View commit details
    Browse the repository at this point in the history

  6. Optimize loadMultiImageOCIArchive a bit 

    Introduce copyFromOCIArchiveReaderReferenceAndManifestDescriptor and
storageReferenceFromOCIArchiveDescriptor , and use that so that
we don't need to load manifest descriptors which we already have
readily available.

Signed-off-by: Miloslav Trmač <[email protected]>
    @mtrmac
    mtrmac committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    456c27d View commit details
    Browse the repository at this point in the history

  7. Remove (broken) references to pkg/errors 

    Signed-off-by: Miloslav Trmač <[email protected]>
    @mtrmac
    mtrmac committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    8637c71 View commit details
    Browse the repository at this point in the history

  8. Fix various warnings 

    Signed-off-by: Miloslav Trmač <[email protected]>
    @mtrmac
    mtrmac committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    278b203 View commit details
    Browse the repository at this point in the history

  9. DO NOT MERGE: (gofmt -s -w) blindly to shut up golangci-lint 

    Signed-off-by: Miloslav Trmač <[email protected]>
    @mtrmac
    mtrmac committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    588a84d View commit details
    Browse the repository at this point in the history