Define Makefile with golangci-lint #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While you're at it, do you want to also add a lint.sh for people to run manually? Or just add a Makefile? (can be a separate PR) |
mmorel-35
changed the title
squeed
reviewed
Apr 21, 2023
As govet and gofmt are now handled by golangci-lint, there is no need to apply them here. Install golangci-lint Signed-off-by: Matthieu MOREL <[email protected]>
|
@squeed , |
squeed
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As govet and gofmt are now handled by golangci-lint, there is no need to apply them here.
Signed-off-by: Matthieu MOREL [email protected]