Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golangci-lint to v1.57.1 #1063

Conversation

austinvazquez
Copy link
Contributor

@austinvazquez austinvazquez commented Feb 11, 2024

Issue:

New golangci-lint version is available.

Description:

This change updates golangci-lint in CI to v1.57.1.

Testing:

Lint check passes

@coveralls
Copy link

coveralls commented Feb 11, 2024

Coverage Status

coverage: 63.609%. remained the same
when pulling 52babb0 on austinvazquez:update-golangci-lint-action-package
into 9f32fa3 on containernetworking:main.

Copy link
Contributor

@bleggett bleggett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@austinvazquez austinvazquez force-pushed the update-golangci-lint-action-package branch from 8accbcf to 317e925 Compare March 21, 2024 18:54
@squeed
Copy link
Member

squeed commented Mar 25, 2024

@austinvazquez thanks! Look like the action was bumped by dependabot, but not the golangci-lint. Can you rebase?

@austinvazquez austinvazquez force-pushed the update-golangci-lint-action-package branch 2 times, most recently from 74ad39c to e112f8f Compare March 25, 2024 14:44
@austinvazquez austinvazquez changed the title Update golangci-lint-action package to v4 Update golangci-lint to v1.57.1 Mar 25, 2024
@austinvazquez austinvazquez force-pushed the update-golangci-lint-action-package branch from e112f8f to 01df056 Compare March 25, 2024 14:48
@austinvazquez
Copy link
Contributor Author

@squeed, thanks for taking a look. I have rebased and updated the commit and PR description to match the new intent.

@squeed squeed force-pushed the update-golangci-lint-action-package branch from 01df056 to 52babb0 Compare May 13, 2024 14:40
@squeed squeed merged commit c04330e into containernetworking:main May 13, 2024
3 checks passed
@austinvazquez austinvazquez deleted the update-golangci-lint-action-package branch May 16, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants