Add MTU to CNI result #1060
Merged
Add MTU to CNI result #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @squeed as we spoke in the meeting this week here is the small PR let me know if there is something else needed. |
squeed
approved these changes
Feb 19, 2024
bleggett
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
There was a good point brought up that we could put this in a metadata struct, but I think MTU is pretty unambiguously a core property of the interface so it makes sense here to me.
Another good point was brought up that if MTU is altered out-of-band, this value could be stale, but I think that's generally true of most things here.
SchSeba
force-pushed
the
add_mtu
branch
3 times, most recently
from
b819be1
to
d9a31ca
Compare
|
/lgtm |
s1061123
requested changes
Mar 13, 2024
This commit allow CNIs to expose the MTU of interface Signed-off-by: Sebastian Sch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allow CNIs to expose the MTU of interface