update review comments

containernetworking · Mar 4, 2024 · 2e39b26 · 2e39b26
1 parent fe443c5
commit 2e39b26
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/SPEC.md b/SPEC.md
@@ -568,7 +568,7 @@ Plugins must output a JSON object with the following keys upon a successful `ADD
     - `name` (string): The name of the interface.
     - `mac` (string): The hardware address of the interface (if applicable).
     - `sandbox` (string): The isolation domain reference (e.g. path to network namespace) for the interface, or empty if on the host. For interfaces created inside the container, this should be the value passed via `CNI_NETNS`.
-    - `socket_path` (string, optional): An absolute path to a socket file corresponding to this interface, if applicable.
+    - `socketPath` (string, optional): An absolute path to a socket file corresponding to this interface, if applicable.
     - `pciID` (string, optional): The platform-specific identifier of the PCI device corresponding to this interface, if applicable.
 - `ips`: IPs assigned by this attachment. Plugins may include IPs assigned external to the container.
     - `address` (string): an IP address in CIDR notation (eg "192.168.1.3/24").

diff --git a/pkg/types/100/types.go b/pkg/types/100/types.go
@@ -271,8 +271,8 @@ type Interface struct {
 	Name       string `json:"name"`
 	Mac        string `json:"mac,omitempty"`
 	Sandbox    string `json:"sandbox,omitempty"`
-	SocketPath string `json:"socket_path,omitempty"`
-	PciID      string `json:"pci_id,omitempty"`
+	SocketPath string `json:"socketPath,omitempty"`
+	PciID      string `json:"pciID,omitempty"`
 }
 
 func (i *Interface) String() string {

diff --git a/pkg/types/100/types_test.go b/pkg/types/100/types_test.go
@@ -108,8 +108,8 @@ var _ = Describe("Current types operations", func() {
             "name":        "eth0",
             "mac":         "00:11:22:33:44:55",
             "sandbox":     "/proc/3553/ns/net",
-            "pci_id": 	   "8086:9a01",
-            "socket_path": "/path/to/vhost/fd"
+            "pciID": 	   "8086:9a01",
+            "socketPath":  "/path/to/vhost/fd"
         }
     ],
     "ips": [

diff --git a/pkg/version/version_test.go b/pkg/version/version_test.go
@@ -42,8 +42,8 @@ var _ = Describe("Version operations", func() {
 						"name":        "eth0",
 						"mac":         "00:11:22:33:44:55",
 						"sandbox":     "/proc/3553/ns/net",
-						"pci_id":      "8086:9a01",
-						"socket_path": "/path/to/vhost/fd"
+						"pciID":       "8086:9a01",
+						"socketPath":  "/path/to/vhost/fd"
 					}
 				],
 				"ips": [