-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(*): publish oci-tar-builder binary in the ci #547
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
I was thinking #524 would be part of the release CI as well. Would we want to sign it too? |
Ah yea I intend to work on another PR to add the release of the bianry as part of the release ci.
sure :) |
I think I have a preference for modify the |
I agree with both of these comments.
I prefer the first option. I would even defer that logic to the makefile, which already has similar logic. |
closes #524
I didn't like the fact that the published artifacts has prefixed name
containerd-shim-
which doesn't really fit the purpose of theoci-tar-builder
.The
oci-tar-builder
binary is built for each Linux, Windows and Macos-x86_64 and Macos-arm64