Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DumpFile operations #616

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

fappy1234567
Copy link
Contributor

  • Modify operations to use memory instead of disk

@fappy1234567 fappy1234567 force-pushed the no-disk-write branch 2 times, most recently from eb1526a to 606c148 Compare September 11, 2024 13:02
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 108 lines in your changes missing coverage. Please review.

Project coverage is 21.93%. Comparing base (e22e77d) to head (29243e3).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
pkg/store/database.go 0.00% 30 Missing and 1 partial ⚠️
pkg/daemon/daemon.go 0.00% 25 Missing ⚠️
pkg/filesystem/fs.go 0.00% 19 Missing ⚠️
pkg/manager/manager.go 0.00% 12 Missing ⚠️
config/daemonconfig/daemonconfig.go 0.00% 8 Missing ⚠️
pkg/manager/daemon_adaptor.go 0.00% 7 Missing ⚠️
pkg/store/daemonstore.go 0.00% 4 Missing ⚠️
config/daemonconfig/fuse.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #616      +/-   ##
==========================================
+ Coverage   21.82%   21.93%   +0.10%     
==========================================
  Files         122      122              
  Lines       10730    10839     +109     
==========================================
+ Hits         2342     2377      +35     
- Misses       8070     8140      +70     
- Partials      318      322       +4     
Files with missing lines Coverage Δ
config/daemonconfig/fscache.go 0.00% <ø> (ø)
config/daemonconfig/fuse.go 0.00% <0.00%> (ø)
pkg/store/daemonstore.go 0.00% <0.00%> (ø)
pkg/manager/daemon_adaptor.go 0.00% <0.00%> (ø)
config/daemonconfig/daemonconfig.go 43.05% <0.00%> (+2.79%) ⬆️
pkg/manager/manager.go 0.00% <0.00%> (ø)
pkg/filesystem/fs.go 0.00% <0.00%> (ø)
pkg/daemon/daemon.go 0.00% <0.00%> (ø)
pkg/store/database.go 40.43% <0.00%> (-8.25%) ⬇️

... and 7 files with indirect coverage changes

@fappy1234567 fappy1234567 force-pushed the no-disk-write branch 27 times, most recently from a507f6b to e272e20 Compare September 18, 2024 01:54
@fappy1234567 fappy1234567 force-pushed the no-disk-write branch 2 times, most recently from c93d8c7 to 30edd41 Compare September 20, 2024 01:57
@fappy1234567 fappy1234567 changed the title WIP: Remove DumpFile operations Remove DumpFile operations Sep 25, 2024
@@ -16,8 +16,11 @@ RUN apk add -q --no-cache curl && \
FROM base AS kubectl-sourcer
ARG TARGETARCH

# RUN apk add -q --no-cache curl && \
# curl -fsSL -o /usr/bin/kubectl https://storage.googleapis.com/kubernetes-release/release/"$(curl -L -s https://dl.k8s.io/release/stable.txt)"/bin/linux/"$TARGETARCH"/kubectl && \
# chmod +x /usr/bin/kubectl
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should remove the useless codes.

snapshotID := supplementInfo.SnapshotID
labels := supplementInfo.Labels
params := supplementInfo.Params
err = daemonconfig.SupplementDaemonConfig(cfg, imageID, snapshotID, false, labels, params)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we pass the entire supplementInfo to SupplementDaemonConfig?

@@ -99,7 +99,8 @@ install::kind(){
}

install::kubectl(){
local version="${1:-}"
#local version="${1:-}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

@fappy1234567 fappy1234567 force-pushed the no-disk-write branch 11 times, most recently from 96575e2 to 437b404 Compare September 26, 2024 13:29
@fappy1234567 fappy1234567 force-pushed the no-disk-write branch 11 times, most recently from 7315695 to a8c16bb Compare October 15, 2024 13:32
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@imeoer imeoer merged commit e55ae70 into containerd:main Oct 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants