tests/converter: modify unpack testcase #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #614 +/- ##
==========================================
- Coverage 22.07% 22.04% -0.04%
==========================================
Files 122 122
Lines 10768 10784 +16
==========================================
Hits 2377 2377
- Misses 8070 8086 +16
Partials 321 321
|
|
The smoke test should work properly if this PR is applied. |
imeoer
reviewed
Sep 15, 2024
pkg/converter/tool/builder.go
Outdated
| @@ -305,7 +305,41 @@ func Unpack(option UnpackOption) error { | |||
| } | |||
|
|
|||
| if option.BackendConfigPath != "" { | |||
| args = append(args, "--backend-config", option.BackendConfigPath) | |||
| configFile, err := os.Open(option.BackendConfigPath) | |||
There was a problem hiding this comment.
It seems the configFile not used.
imeoer
reviewed
Sep 15, 2024
pkg/converter/tool/builder.go
Outdated
| return errors.Wrapf(err, "fail to marshal backend config %v", backendConfig) | ||
| } | ||
|
|
||
| logrus.Errorf("Backend config: %s", backendConfigBytes) |
There was a problem hiding this comment.
The backend config maybe contains secret data, we shouldn't print it.
imeoer
reviewed
Sep 15, 2024
SToPire
force-pushed
the
unpack-test
branch
from
608c7df
to
bc11b08
Compare
SToPire
force-pushed
the
unpack-test
branch
from
a75fc14
to
ab1fe00
Compare
This patch modifies the unpack testcase to keep consistent with the new `nydus-image unpack` interface in nydus-image. Signed-off-by: Yifan Zhao <[email protected]>
The Go package `user` has a `Current` method that returns the current user. We should use `user.Current().Username` instead of `user.Current().Name` to get the current username. This patch fixes it. Signed-off-by: Yifan Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch modifies the unpack testcase to keep consistent with the new
nydus-image unpackinterface in nydus-image.