Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: resume nydusd processes parallelizilly #518

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

loheagn
Copy link
Contributor

@loheagn loheagn commented Aug 9, 2023

This patch allows the snapshotter resumes the recovering nydusd daemons parallelizilly in the starting stage.

fix #505

This patch allows the snapshotter resumes the recovering nydusd daemons parallelizilly in the starting stage.

Signed-off-by: Nan Li <[email protected]>
@loheagn
Copy link
Contributor Author

loheagn commented Aug 9, 2023

Hi, @changweige, in my option, there is no concern about the concurrency conflicts when resuming multi nydusd daemons at the same time, so I just use errorGroup to parallelize the nydusd daemons resuming. Any comments?

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@sctb512 sctb512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@changweige changweige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@changweige changweige merged commit 732d9a6 into containerd:main Aug 16, 2023
15 checks passed
@loheagn loheagn deleted the parallelize-nydusd-setup branch August 16, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

recover nydusd faster
4 participants