feat: prevent unnecessary conversions #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imeoer
reviewed
Aug 9, 2023
PerseidMeteor
force-pushed
the
feat-remote-cache
branch
3 times, most recently
from
3d64269
to
58fa183
Compare
|
Please also add commit message explaining why and how. :) |
PerseidMeteor
force-pushed
the
feat-remote-cache
branch
2 times, most recently
from
09f7ab6
to
4ea9549
Compare
sctb512
reviewed
Aug 15, 2023
PerseidMeteor
force-pushed
the
feat-remote-cache
branch
2 times, most recently
from
50e9a10
to
a138538
Compare
If content store provides remote cache, we can use remote cache to avoid unnecessary conversions. The layer converted using cache is the same as the layer converted normally, both containing two annotations: LayerAnnotationUncompressed, LayerAnnotationNydusBlob. Also add two constant LayerAnnotations labels. Signed-off-by: breezeTuT <[email protected]>
PerseidMeteor
force-pushed
the
feat-remote-cache
branch
from
a138538
to
bf7032c
Compare
imeoer
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add remote cache of remote registry.
Changes: