config: remove useless auth_through option #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have removed the `auth_through` option in dragonflyoss/nydus#1375 Let's remove it in snapshotter, since its default value is false, there is no compatibility impact. Signed-off-by: Yan Song <[email protected]>
|
Does it mean that all auth requests directly go to the original registry? The capability to get auth from the mirror registry is removed. |
It's right, all auth requests will be sent to original registry auth server. |
|
Though this PR is not a breaking change, should we have a place to record the commits that ever changed UI like configuration file? So we can public them when composing release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have removed the
auth_throughoption in dragonflyoss/nydus#1375Let's remove it in snapshotter, since its default value is false, there is no compatibility impact.