Remove some unused code and updated docs for metrics #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root directory is not used by metrics server forever because we have remove the function to dump metrics to a file in root directory. Signed-off-by: Bin Tang <[email protected]>
changweige
reviewed
Jul 14, 2023
docs/configure_nydus.md
Outdated
| @@ -129,6 +129,8 @@ The Nydus snapshotter will get the new secret and parse the authorization. If yo | |||
| ## Metrics | |||
|
|
|||
| Nydusd records metrics in its own format. The metrics are exported via a HTTP server on top of unix domain socket. Nydus-snapshotter fetches the metrics and convert them in to Prometheus format which is exported via a network address. Nydus-snapshotter by default does not fetch metrics from nydusd. You can enable the nydusd metrics download by assigning an network address to `metrics.address` in nydus-snapshotter's toml [configuration file](../misc/snapshotter/config.toml). | |||
There was a problem hiding this comment.
Can you also help correct the typo an network
Signed-off-by: Bin Tang <[email protected]>
sctb512
force-pushed
the
remove-unused-code
branch
from
ee5d97f
to
e35a800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.