transmit log rotation max size to nydus daemon

[sctb512]

Currently, the maximum log rotation size is not passed to the nydus daemon. It would be better to allow users to set this value.

[codecov]

Codecov Report

Merging #507 (725f272) into main (3338db6) will decrease coverage by 0.06%.
The diff coverage is 14.28%.

❗ Current head 725f272 differs from pull request most recent head ea93602. Consider uploading reports for the commit ea93602 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
- Coverage   37.91%   37.85%   -0.06%     
==========================================
  Files          60       60              
  Lines        7074     7087      +13     
==========================================
+ Hits         2682     2683       +1     
- Misses       4080     4092      +12     
  Partials      312      312              

Impacted Files	Coverage Δ
config/config.go	31.38% <ø> (ø)
config/global.go	31.64% <0.00%> (-0.83%)	⬇️
pkg/daemon/config.go	0.00% <0.00%> (ø)
pkg/daemon/daemon.go	0.00% <ø> (ø)
pkg/manager/daemon_adaptor.go	0.00% <0.00%> (ø)
pkg/daemon/command/command.go	59.04% <20.00%> (-2.34%)	⬇️
config/default.go	86.95% <100.00%> (+0.28%)	⬆️

[changweige]

Does rotation size need to be persisted ? can it come from the global configs set each time nydusd runs

[sctb512]

I want to follow the store way of LogLevel. So I added it into this structure. This is a parameter for the daemon. So I believe this is also reasonable.

[changweige]

It's fine. By adding LogRotationSize to the DB record, we have to consider compatibility. It's possible to be zero when loading from an old nydusd record, and how do you make it apply to an old running nydusd if you never update its DB record. Moverover, if it's zero we don't have to append the argument log-rotation-size to CLI

[sctb512]

if it's zero we don't have to append the argument log-rotation-size to CLI

Yes, you are right. Fixed. Now, the LogRotationSize will be omitted if it is zero when building command arguments.

[changweige]

LGTM