don't let codecov tool comment everywhere in PR #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imeoer
approved these changes
Jun 29, 2023
adamqqqplay
reviewed
Jun 29, 2023
| comment: | ||
| layout: "reach, diff, flags, files" | ||
| behavior: default | ||
| require_changes: false # if true: only post the comment if coverage changes |
There was a problem hiding this comment.
@changweige Maybe set this value to true could solve the problem.
adamqqqplay
reviewed
Jun 29, 2023
.github/codecov.yml
Outdated
| # comment: | ||
| # layout: "reach, diff, flags, files" | ||
| # behavior: default | ||
| # require_changes: false # if true: only post the comment if coverage changes | ||
|
|
||
| codecov: | ||
| require_ci_to_pass: false | ||
| notify: | ||
| wait_for_ci: false |
There was a problem hiding this comment.
This value could set to true too.
6 tasks
|
@changweige I submitted a similar PR in the nydus repository: dragonflyoss/nydus#1350, please take a look. Thanks! |
Signed-off-by: Changwei Ge <[email protected]>
changweige
force-pushed
the
dont-let-codecov-comment
branch
from
adb4bc5
to
4a7ac09
Compare
Thanks for the reminder. Already follows your PR. |
adamqqqplay
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It messes up the PR code change page.