yarn: frozen-lockfile integration test #683
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes containerbuildsystem#655 The integration test covers a scenario when running `yarn install ...` command will fail becuase of new dependencies that were added to package.json and yarn.lock would have to updated to reflect these changes. Signed-off-by: Michal Šoltis <[email protected]>
|
Related PR: cachito-testing/cachi2-yarn#1 |
The way the issue is currently written then this PR definitely doesn't resolve it, it only addresses one of the list items. Depending on the consensus on #655 (comment) this PR might eventually be merged as is OR it'll need an additional inverted test (i.e. removing deps). |
|
https://github.com/cachito-testing/cachi2-yarn/tree/invalid_frozen_lockfile When I manually ran the command |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #655
The integration test covers a scenario when running
yarn install ...command will fail becuase of new dependencies that were added to package.json and yarn.lock would have to updated to reflect these changes.Maintainers will complete the following section
Note: if the contribution is external (not from an organization member), the CI
pipeline will not run automatically. After verifying that the CI is safe to run:
/ok-to-test(as is the standard for Pipelines as Code)