Fix positive UTC offset parsing in DateTimeConverter #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirsan31
added a commit
to kirsan31/quickfixn
that referenced
this pull request
Aug 18, 2023
gbirchmeier
reviewed
Jan 18, 2024
| @@ -71,8 +71,8 @@ private static System.DateTime ConvertFromNanoString(string str, string[] format | |||
| { | |||
| // GMT offset | |||
| int n = dec.Contains("+") ? dec.IndexOf('+') : dec.IndexOf('-'); | |||
| kind = System.DateTimeKind.Utc; | |||
| offset = int.Parse(dec.Substring(n + 1)); | |||
The sign of the offset was not being considered which happened to work for negative offsets. Positive offsets would be adjusted in the wrong direction which was not caught due to an incorrect test.
gbirchmeier
force-pushed
the
datetimefix
branch
from
8ecda11
to
31a6643
Compare
|
I rebased and updated release notes. Will merge when checks pass. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sign of the offset was not being considered which happened to work for negative offsets. Positive offsets would be adjusted in the wrong direction which was not caught due to an incorrect test.
I have a larger change/proposal coming in a separate PR (edit: #765). This one is a bit easier to digest.