-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suitesparse 5.7.2 (redux) #64
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2020.04.12.13.56.44
The two extant patches have been upstreamed by @minrk in DrTimothyAldenDavis/SuiteSparse#7 & DrTimothyAldenDavis/SuiteSparse#8, so I removed them outright. |
@conda-forge/suitesparse |
PS. Link to the discussion about the conda-smithy warning regarding license identifiers. |
Thanks @h-vetinari. Not having the patches should make future automatic updates easier! |
Happy to help. I want to fix the suboptimal cvxopt build (currently building and statically linking suitesparse for windows within that recipe), so it made sense to start here. In turn, this also means that cvxopt already knows how to build suitesparse for windows, so I'm hopeful I can leverage that (somehow) into a windows build here (cf. #51).
All credit for that belongs to @minrk! :) |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)This picks up the fixed patches from @minrk in #61, together with the version bump from #63.
Closes #60
Closes #61
Closes #62
Closes #63