Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suitesparse 5.7.2 (redux) #64

Merged
merged 7 commits into from
Apr 13, 2020
Merged

suitesparse 5.7.2 (redux) #64

merged 7 commits into from
Apr 13, 2020

Conversation

h-vetinari
Copy link
Member

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This picks up the fixed patches from @minrk in #61, together with the version bump from #63.

Closes #60
Closes #61
Closes #62
Closes #63

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

@h-vetinari
Copy link
Member Author

@conda-forge-admin, please rerender

@h-vetinari
Copy link
Member Author

The two extant patches have been upstreamed by @minrk in DrTimothyAldenDavis/SuiteSparse#7 & DrTimothyAldenDavis/SuiteSparse#8, so I removed them outright.

@h-vetinari
Copy link
Member Author

@conda-forge/suitesparse
This is green and should allow to close all open PRs. Next step: windows builds. ;-)

@h-vetinari
Copy link
Member Author

h-vetinari commented Apr 12, 2020

PS. Link to the discussion about the conda-smithy warning regarding license identifiers.

@grlee77 grlee77 merged commit a3425e9 into conda-forge:master Apr 13, 2020
@grlee77
Copy link
Member

grlee77 commented Apr 13, 2020

Thanks @h-vetinari. Not having the patches should make future automatic updates easier!

@h-vetinari
Copy link
Member Author

@grlee77: Thanks @h-vetinari.

Happy to help. I want to fix the suboptimal cvxopt build (currently building and statically linking suitesparse for windows within that recipe), so it made sense to start here. In turn, this also means that cvxopt already knows how to build suitesparse for windows, so I'm hopeful I can leverage that (somehow) into a windows build here (cf. #51).

Not having the patches should make future automatic updates easier!

All credit for that belongs to @minrk! :)

@h-vetinari h-vetinari deleted the 5.7.2 branch April 14, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants