-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pytorch 2.4.1, python 3.13, cudnn9 #261
Pytorch 2.4.1, python 3.13, cudnn9 #261
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
cudnn 9 would make this package incompatible with cupy. Would it be appropriate to build out 2 versions, one for cudnn 9, the other for cudnn 8??? |
47a96d9
to
2665bfd
Compare
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I thought that it i could get things to work by downgrading to 2.4.0 instead of 2.4.1.... but it still doesn't work |
It looks like it's going ok so far? :) |
No I ran it locally in docker on a linux-64 host and ran into the same problem as |
0ffc036
to
4f14b13
Compare
7b062b5
to
da0e9fd
Compare
da0e9fd
to
be0a19c
Compare
Am seeing the following error in this CI job (with attached log):
Edit: Another jobs fails with the same error |
its probably because i hardcoded the numpy include dir and its frozen in. |
What if we added a symlink to the NumPy headers using a Python version agnostic location and provided the latter as input? |
you are welcome to try, i can back off. |
actuallly my guess is that cmake is invoked through a new codepath i didn't capture in my patch. |
I trust your judgment Mark. Please let me know if I'm just missing things Edit: Fixed a typo |
I’m too tired for today. Just giving ideas. |
…nda-forge-pinning 2024.10.04.13.32.50
I think it is a difference between numpy 2.0 and 2.1. Is there a reason to to build with 2.0 vs 2.1? The reason i ask is that the migration pins to 2.0: |
…nda-forge-pinning 2024.10.04.13.32.50
Just because we started out conservatively. You can use 2.1 without issue, or pin to |
i'm not so convinced about my 2.1 theory anymore. I had successful builds with Linux64 and aarch64 in the past... |
@isuruf it seems the sed “fix” was at the source of the issue. Any other ideas on how to make sed better? Or should we just restart builds periodically. |
…nda-forge-pinning 2024.10.04.13.32.50
Well thank you all!!!!! |
Hooray! 🥳 Thanks everyone! 🙏 |
This PR has been triggered in an effort to update python313.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.
Also includes...
Fixes #264
Fixes #259