-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cmake scripts #85
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.03.29.16.02.14
@@ -5,5 +5,6 @@ set -euxo pipefail | |||
export ONNX_ML=1 | |||
# build script looks at this, but not set on | |||
export CONDA_PREFIX="$PREFIX" | |||
export CMAKE_ARGS="${CMAKE_ARGS} -DProtobuf_PROTOC_EXECUTABLE=$BUILD_PREFIX/bin/protoc -DProtobuf_LIBRARY=$PREFIX/lib/libprotobuf${SHLIB_EXT}" | |||
export CMAKE_ARGS="${CMAKE_ARGS} -DBUILD_SHARED_LIBS=ON -DProtobuf_PROTOC_EXECUTABLE=$BUILD_PREFIX/bin/protoc -DProtobuf_LIBRARY=$PREFIX/lib/libprotobuf${SHLIB_EXT}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, does this change also install ONNX cmake files so users can link against this libonnx.so
?
It would be great to have them, we are one of the users :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly! You can check the files being installed around here
@ilya-lavrenov As mentioned above, attempts have been made on Windows but I couldn't link |
CMAKE_ARGS
libonnx
(mitigates Build this aslibonnx
#77) along with CMake configuration scriptslibprotobuf
on conda-forge andonnx
, which causesunresolved external symbol
s. To correctly linklibprotobuf
we might need to build it locally and use static linking as per here and here. I'm leaving that decision to future works.Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)