Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild 0.12.15 for python 3.11 #100

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

synapticarbors
Copy link
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This is an older version of maturin that we don't currently have on conda-forge. I'm attempting to build it since connectorx pins to >=0.12,<0.13, but the available builds satisfying that (latest is 0.12.15) on conda-forge currently don't support python 3.11. This is blocking connectorx from building on python 3.11. connectorx is used by polars and modin for pulling data from a database into a dataframe. This was the last version of pypi before 0.13.0.

I'm not sure if this should be merged into main or a separate branch.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@synapticarbors
Copy link
Member Author

I forgot about all of the problems we had with some of the later 0.12 packages. I'm backing up to 0.12.15, which is the last build that worked.

@synapticarbors synapticarbors changed the title Add v0.12.20 Rebuild 0.12.15 for python 3.11 Jul 27, 2023
@synapticarbors
Copy link
Member Author

@messense @apcamargo -- It looks like everything is passing on this now. How do you want to handle this?

@messense
Copy link
Contributor

I'm fine with merging this, but I don't know the process to handle old versions.

@messense
Copy link
Contributor

I've opened sfu-db/connector-x#523 to upgrade maturin to 1.0 for connectorx.

@synapticarbors
Copy link
Member Author

I guess there are two options. One is to merge this into another branch, which will get built automatically. The other is to merge it into main as a one-off, and then when the next new version of maturin is released, just revert the few changes I made to handle the older version. For the latter, we might want to disable the automerge, but maybe that isn't necessary since it would failed anyway without setuptools-rust.

@MementoRC
Copy link

MementoRC commented Feb 26, 2024

Would it be possible to merge this PR? Also, would it be possible to add 3.12 support? I am working on pybip39 that requires <0.13 and effectively fails with 0.14.17 (the version that has 3.12 in conda-forge)

@synapticarbors
Copy link
Member Author

Doesn't pybip39 require >14,<15 (https://github.com/polkascan/py-bip39-bindings/blob/master/pyproject.toml#L2)? Or are you working on an older version? It looks like after I put in this PR, @xhochy took the strategy of setting up a 0.14 branch to get py3.12 support, so I guess we could do that with 0.12 as well if needed.

@MementoRC
Copy link

MementoRC commented Feb 26, 2024

py-bip39-bindings is a different package that effectively can use 0.14, however pybip39 does not compile with 0.14:
https://github.com/kevinheavey/pybip39/blob/main/pyproject.toml

Though, that is a great point, both of those are supposed to be doing the same thing and I actually only need pybip39 for a testsuite for solders, so I could simply patch the test using py-bip39-bindings instead. Let me go back to the drawing board and get back to you

@MementoRC
Copy link

Well, I will simply remove the failing tests, pybip39 is not fully compatible with py-bip39-bindings. I'll leave the pybip39 alone for now, or try to see if the author can update it to 0.14
Thx

@MementoRC
Copy link

Just FYI, it turns out that the Cargo.toml requests PyO3=0.15.1 with features that within conda-build defaults to 0.15.2, with which the compilation fails.
After a bit of tweaking, PyO3=0.16.6 compiles, is selectable within conda-build and is compatible with maturin=0.14. I submitted the PR, but I don't know if it meets Conda-Forge standards:
conda-forge/staged-recipes#25586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants