-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for hdf5 1.14.4 #65
base: main
Are you sure you want to change the base?
Rebuild for hdf5 1.14.4 #65
Conversation
…nda-forge-pinning 2024.10.03.22.00.47
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi @petebunting any idea why this would fail on OSX? Have you had any trouble with hdf5 1.14.4 there? |
Hi @gillins, No is the simple answer. I've not had any problems with rsgislib building against hdf5. I only have ARM Macs these days, but I can try a local build later today to see if I can replicate it. |
It's weird because osx_arm64 succeeded... |
Ah actually osx arm64 is cross compiled so it doesn't run the tests. Thanks for having a look Pete - interested to hear what you find with hdf5 1.14.4... |
@gillins it didn't look to me that the test was running on OSX arm where the error was occurring... If I remember correctly from setting up the rsgislib osx arm build it is difficult to run the tests on osx arm as it cross compiled or something. If it isn't running the test then it might not be finding the error... |
@petebunting just seen this: conda-forge/hdf5-feedstock#232 - might be the problem? Weird how it was only on OSX for us... |
@conda-forge-admin, please restart ci |
@jschueller any ideas about this crash with HDF5 C++? Seems different to the one you've recently fixed... |
dont know, maybe its due to clang17 since its only happening on osx |
I had to roll back to clang 15 elsewhere (conda-forge/hdfeos5-feedstock#42 and conda-forge/libcdms-feedstock#56). Maybe that's the way forward here, too, so the migration can progress? |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.10.07.21.36.54
Okay, not that then. Sorry for leading you astray. |
I'm now getting compile errors, rather than segfaults on osx:
Any thoughts? |
I'm afraid I don't have any idea. I'd suggest going back to clang 17. I now see that worked fine for you in #64 so no reason to go back to an earlier version. I would suggest trying to get more verbose output from ctest instead (after going back to clang 17). |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.10.07.21.36.54
Unfortunately, not hugely informative:
|
It's so weird that it's only osx... @petebunting if you could get a chance to look at this and see what is going on that would be great, otherwise I guess we'll have to skip osx (or maybe just the tests but that seems dangerous) for now so the migration can continue. |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.10.10.19.24.06
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.10.10.19.24.06
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.10.10.19.24.06
@conda-forge-admin, please rerender |
@h-vetinari is it possible because of the way I'm running |
…nda-forge-pinning 2024.10.12.07.48.22
I stumbled into this PR being important for conda-forge dependency troubles attm, so hopefully you don't mind a drive-by rerender to see if this somehow works now :/ @conda-forge-admin, please rerender |
…nda-forge-pinning 2024.10.25.11.54.39
Looking at the failed log, this combination of packages seems strange to me, installed with the same buildstep
I am likely just making noise, but try adding the |
Hi @gillins Sorry it has taken me such a long while to look at this again. As you say, I think it is a compiler issue. I've just done a local build of both hdf 1.14.5 (latest from hdf5 releases) and kea 1.6.0 and run the kea test1 binary and it worked returning 'Success', which it wasn't doing using the conda-forge hdf5 binary so I don't think it is a bug or something within the hdf5 code. Tested on an M2 MBP. |
@petebunting, I had suspected it was something to do with how hdf5 is being built on conda-forge, but we did tests with both 1.14.4 and 1.14.5 and were not able to reproduce the issue over there: I also re-tested with 1.14.3 here and didn't see the error so it doesn't seem to be something that crept into the compilers since your last kealib build: So I'm afraid I haven't been able to narrow down where it's coming from. |
@petebunting can you tell if more than one copy of I guess we are going to have to decide if we skip osx and allow the migration to proceed, or we wait until more information if available... |
I do not recommend this approach, as it means skipping OSX in all downstream migrations. We ended up in a nightmare but doing something similar with ppc64le in the recent past (in that case for the proj library) and the trouble was more than we faced in the end by just taking the time to figure out the problem. It is better to have the migration stuck than to have it proceed only half working. |
Very sorry that I missed this ping. I see you have Isuru's attention already, so you should be on great hands. :) |
This PR has been triggered in an effort to update hdf51144.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/11171199416 - please use this URL for debugging.