Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/dpcpp headers location and metadata #40

Merged

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Jun 25, 2024

These changes are target to resolve #31, #32 and update dependencies the way the compiler may be used independently of other compilers. So users typical usage will look like:

build:
  - compiler('dpcpp')
  - stdlib('c')

instead of

build:
  - compiler('c')
  - compiler('dpcpp')
  - stdlib('c')

Changes also allow older versions of gcc be used with the dpcpp compiler, that supported by the compiler: https://www.intel.com/content/www/us/en/developer/articles/system-requirements/intel-oneapi-dpcpp-system-requirements.html .

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes #31
Fixes #32

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • pin_compatible should be used instead of pin_subpackage for dpcpp_impl_win-64 because it is not a known output of this recipe: ['intel-cmplr-lic-rt', 'intel-cmplr-lib-rt', 'intel-fortran-rt', 'intel-opencl-rt', 'dpcpp-cpp-rt', 'dpcpp_impl_linux-64', 'dpcpp_linux-64', 'oneccl-devel', 'intel-compiler-repack'].

For recipe:

  • This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.

  • You're setting a requirement on sysroot_linux- directly; this should now be done by adding a build dependence on {{ stdlib("c") }}, and overriding c_stdlib_version in recipe/conda_build_config.yaml for the respective platform as necessary. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.

  • In conda-forge.yml: $.build_with_mambabuild = False.

    'Build With Mambabuild' is deprecated.
    build_with_mambabuild is deprecated, use conda_build_tool instead.

    Schema
    {
      "anyOf": [
        {
          "type": "boolean"
        },
        {
          "type": "null"
        }
      ],
      "default": true,
      "deprecated": true,
      "title": "Build With Mambabuild"
    }

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

For recipe:

  • In conda-forge.yml: $.build_with_mambabuild = False.

    'Build With Mambabuild' is deprecated.
    build_with_mambabuild is deprecated, use conda_build_tool instead.

    Schema
    {
      "anyOf": [
        {
          "type": "boolean"
        },
        {
          "type": "null"
        }
      ],
      "default": true,
      "deprecated": true,
      "title": "Build With Mambabuild"
    }

@ZzEeKkAa
Copy link
Contributor Author

@conda-forge-admin, please rerender

Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/intel-compiler-repack-feedstock/actions/runs/9684616184.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

@ZzEeKkAa
Copy link
Contributor Author

@conda-forge-admin, please rerender

@ZzEeKkAa
Copy link
Contributor Author

ZzEeKkAa commented Jun 26, 2024

New dependency list:

$ conda search local::dpcpp_impl_linux-64=2024.1.0 --info
Loading channels: done
dpcpp_impl_linux-64 2024.1.0 hb3a4779_964
-----------------------------------------
file name   : dpcpp_impl_linux-64-2024.1.0-hb3a4779_964.conda
name        : dpcpp_impl_linux-64
version     : 2024.1.0
build       : hb3a4779_964
build number: 964
size        : 244.1 MB
license     : LicenseRef-Proprietary-Intel-End-User-License-Agreement-for-Developer-Tools
subdir      : linux-64
url         : file:///home/jovyan/.miniforge3/conda-bld/linux-64/dpcpp_impl_linux-64-2024.1.0-hb3a4779_964.conda
md5         : 51c04b408a45848edd97979dd9b88b94
timestamp   : 2024-06-26 20:30:11 UTC
dependencies:
  - _openmp_mutex >=4.5
  - binutils_impl_linux-64 >=2.30
  - dpcpp-cpp-rt 2024.1.0 hd93895e_964
  - libgcc-devel_linux-64 >=7.5.0
  - libgcc-ng >=7.5.0
  - libstdcxx-devel_linux-64 >=7.5.0
  - libstdcxx-ng >=7.5.0
  - libxml2 >=2.12.7,<3.0a0
  - libzlib >=1.3.1,<2.0a0
  - ocl-icd >=2.3.2,<3.0a0
  - sysroot_linux-64

$conda search local::dpcpp_linux-64=2024.1.0 --info
Loading channels: done
dpcpp_linux-64 2024.1.0 hb2983c6_964
------------------------------------
file name   : dpcpp_linux-64-2024.1.0-hb2983c6_964.conda
name        : dpcpp_linux-64
version     : 2024.1.0
build       : hb2983c6_964
build number: 964
size        : 29 KB
license     : LicenseRef-Proprietary-Intel-End-User-License-Agreement-for-Developer-Tools
subdir      : linux-64
url         : file:///home/jovyan/.miniforge3/conda-bld/linux-64/dpcpp_linux-64-2024.1.0-hb2983c6_964.conda
md5         : 53ffd06089dea23e62e545fe3453976f
timestamp   : 2024-06-26 20:37:16 UTC
dependencies:
  - binutils_linux-64 >=2.30
  - dpcpp_impl_linux-64 2024.1.0 hb3a4779_964
  - sysroot_linux-64

@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review June 26, 2024 20:52
if [[ "$PKG_NAME" == "dpcpp_impl_linux-64" ]]; then
# Move intel specific headers files from the global include directory to
# allow other compilers work in the same environment.
find ${src}/include -maxdepth 1 -type f -exec mv {} ${src}/opt/compiler/include \;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why opt in path? should this be dpcpp name instead to reflect this is dpcpp specific?

@napetrov napetrov merged commit 1ba8746 into conda-forge:main Jun 26, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants