Add a table for the paused migrators category #2262
Conversation
✅ Deploy Preview for conda-forge-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
HaudinFlorence
force-pushed
the
add_a_table_for_the_paused_migrators_category
branch
from
af06644
to
63d510a
Compare
| if (redirect) return (<Redirect to={redirect} replace={false} push={true} />); | ||
| return ( | ||
| <> | ||
| <thead> | ||
| <tr onClick={select}> | ||
| <th colSpan={8} className={collapsed ? styles.collapsed : undefined}> | ||
| {name}{" "} | ||
| <span className="badge badge--secondary">{rows.length || "…"}</span> | ||
| <span className="badge badge--secondary">{name!=="Paused migrations" ? rows.length || "..." : rows.length || "0"}</span> |
There was a problem hiding this comment.
Are we special casing "Paused migrations" here? I would expect the code to be something like:
- While fetching the remote JSON, the badge says
…(note this is the three period symbol, not three periods one after another like...; this should be reverted). - Once fetched, we calculate the
rows.lengthand then report the number.
Is this too late in the code to check for rows being fetched? 🤔
There was a problem hiding this comment.
Some logics was added to address the mentioned point.
Co-authored-by: jaimergp <[email protected]>
…umber of migrations or 3 periods depending on the result.
|
Great to see this happening! FYI, as of conda-forge/conda-forge-pinning-feedstock#6292, you'll have a paused migrator to play with. ;-) |
There was a problem hiding this comment.
Oops, this logic I added is not correct because long-running ones won't ever make it to the "is it paused" check. I need to adjust a couple things in the bot. I'll do it after lunch :D
|
I submitted a couple fixes to the backend (regro/cf-scripts#2932, regro/cf-graph-countyfair#33) but the paused pypy migrator still doesn't show up as paused... I'll need to look into it. |
|
Yay, thanks to @beckermr's regro/cf-scripts#2940, the paused migrators file is now populated, which means that the table works: 
The only thing I'm missing is some sort of indicator in the details page, like an admonition that says the migrator is paused or closed: Note This migration was recently closed. Or Note This migration is currently paused. The migration file does not include the information needed, but we can check whether the migrator name is in one of the already fetched closed/paused lists. |
PR Checklist:
docs/orcommunity/, you have added it to the sidebar in the corresponding_sidebar.jsonfileThis PR aims at fixing task 9 of meta issue #2137. It adds a new category for paused migrations and add a new corresponding table.
It uses recent PR regro/cf-scripts#2886