Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cuda to 12.6 #6643

Closed
wants to merge 1 commit into from
Closed

Bump cuda to 12.6 #6643

wants to merge 1 commit into from

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Nov 4, 2024

Closes #6630

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@hmaarrfk hmaarrfk requested a review from a team as a code owner November 4, 2024 04:17
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still like to migrate this first; some binaries changed in the early days of the 12.x conda-forge roll-out, but more importantly, many recipes hard-code the cuda_compiler_version in various places (e.g. to determine the set of GPU arches in build.sh), and we shouldn't just break all those recipes IMO.

Finally, we should double-check the GCC upper bound for CUDA 12.6 - we can probably go to GCC 13, matching our non-CUDA stack.

@@ -17,7 +17,7 @@ m2w64_c_stdlib: # [win]
c_stdlib_version: # [unix]
- 2.17 # [linux]
- 2.17 # [linux and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
- 2.17 # [linux and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
- 2.28 # [linux and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CUDA compiler version shouldn't have anything to do with the sysroot we target. Needing newer images to run some of the existing CUDA 12 build infrastructure is solved by bumping the images, not the sysroot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the migrator you have in mind?

I feel like it cna likely be simplified now:

https://github.com/conda-forge/cupy-feedstock/blob/main/.ci_support/migrations/cuda12x.yaml

@hmaarrfk hmaarrfk closed this Nov 4, 2024
@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Nov 4, 2024

I'm pretty bad at writing these zipped migrators and i guess I don't understand why the sysroots need to be updated so I'll let somebody else draft somethung

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate for CUDA 12.x (x to be determined)
3 participants