Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to alma8 by default; add alma9 & enable choice through DEFAULT_LINUX_VERSION #6626

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Oct 29, 2024

Alternative to #6548

Closes #6283
Closes #6629

We can do this because all the required infrastructure is now in place (c.f. conda-forge/conda-forge.github.io#1941); the last missing piece was to verify how entries of yum_requirements.txt match between centos7 & alma8 - the following overview shows that there's a high degree of compatibility (and many things can be replaced by our own build anyway). The handful of differences can be fixed on the affected feedstocks.

Should wait for:

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

respect convenience setting DEFAULT_LINUX_VERSION to avoid feedstocks
having to override the monster-zip just to change c_stdlib_version & image.
@h-vetinari h-vetinari changed the title move to alma8 images move to alma8 by default; add alma9 & enable choice through DEFAULT_LINUX_VERSION Oct 31, 2024
this allows separate overrides for the c_stdlib_version and the image
(the latter can easily be set using `os_version` in `conda-forge.yml`)
@h-vetinari
Copy link
Member Author

For the reasoning behind 24b7e66, see discussion here. The preceding commit fails if a feedstock would override c_stdlib_version, see also this branch where I've tested this for an affected feedstock.

24b7e66 would thus be necessary to make the docker image (sufficiently) independent from c_stdlib_version, so that they can be set independently (if indeed this is something we desire to enable; one reason why is that the image version doesn't have to affect the sysroot-baseline, in particular if it's only for being able to load a build tool or test dependency).

@h-vetinari h-vetinari mentioned this pull request Nov 3, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants