Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.13 migrations #6357

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Add python 3.13 migrations #6357

merged 2 commits into from
Aug 28, 2024

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Aug 28, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@isuruf isuruf requested a review from a team as a code owner August 28, 2024 15:28
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This question is for my own curiosity. Do we need the older python 3.6, 3.7, etc. entries in the ordering key still? If so, why?

@isuruf
Copy link
Member Author

isuruf commented Aug 28, 2024

This question is for my own curiosity. Do we need the older python 3.6, 3.7, etc. entries in the ordering key still? If so, why?

If there's an old migration file for 3.6 or 3.7 or 3.8, conda-smithy will likely break. It's a fragile part of the code and we should get rid of ordering stuff as we have never used those parts of the code

@beckermr
Copy link
Member

Thanks. We needed the ordering stuff for reasons I now forget. Is there an open issue somewhere on this?

@isuruf
Copy link
Member Author

isuruf commented Aug 28, 2024

Not that I recall.

@isuruf
Copy link
Member Author

isuruf commented Aug 28, 2024

Let's see how this goes

@isuruf isuruf merged commit e2b9adf into conda-forge:main Aug 28, 2024
3 checks passed
- 3.7.* *_73_pypy
- 3.8.* *_73_pypy
- 3.9.* *_73_pypy
paused: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that this is paused, so just two questions:

  • Shouldn't we use wait_for_migrators: here to queue this behind the regular 3.13?
  • In the last core call where this was discussed, you had suggested running the freethreading migrator several months after 3.13. Is that still the plan, or what changed to move it forward so much?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's paused for now, but I added it so that we can experiment with it without the need to add the values to cbc. We can unpause after a couple of months maybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants