Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use GHA for service feedstocks and copy in alt arch .txt files #6328

Merged
merged 6 commits into from
Aug 23, 2024

Conversation

beckermr
Copy link
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@beckermr
Copy link
Member Author

@conda-forge-admin rerender

@beckermr beckermr marked this pull request as ready for review August 23, 2024 18:48
@beckermr beckermr requested a review from a team as a code owner August 23, 2024 18:48
@beckermr beckermr changed the title feat: use GHA for service feedstocks feat: use GHA for service feedstocks and copy in alt arch .txt files Aug 23, 2024
@beckermr beckermr merged commit ef3d9d1 into conda-forge:main Aug 23, 2024
3 checks passed
@beckermr beckermr deleted the beckermr-patch-19 branch August 23, 2024 21:45
@jakirkham
Copy link
Member

Are we still able to re-render here or does that not work with these changes?

@beckermr
Copy link
Member Author

We can rerender locally. Happy to revert ofc. This feedstock doesn't need rerendering all that much so I assumed it'd be ok.

@jakirkham
Copy link
Member

jakirkham commented Aug 23, 2024

Probably the better thing to do is for us to figure out how to use GHA as CI and enable bot-based re-rendering since we may need to move more things to GHA in the future (not less). That's a separate discussion though

@beckermr
Copy link
Member Author

Yeah I have a plan for that but it involves some level of refactoring the rendering code for security hardening.

@jakirkham
Copy link
Member

Look forward to reading more details on your plan 🙂

@Tobias-Fischer
Copy link
Contributor

I think this PR broke CI on the main branch

/cc @hmaarrfk

@hmaarrfk
Copy link
Contributor

i feel like a few people have been working to resolve this. I'll take a step back.

@beckermr
Copy link
Member Author

I think this is the heroku server.

@beckermr
Copy link
Member Author

@hmaarrfk
Copy link
Contributor

I guess the symptom is that this package is no longer getting published:
https://github.com/conda-forge/conda-forge-pinning-feedstock/actions/runs/10550981930/job/29227764795

fails

@beckermr
Copy link
Member Author

Ahhhh sorry. I forgot to reset the token and add to gha.

@hmaarrfk
Copy link
Contributor

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants