Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pin for suitesparse #5835

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update the pin for suitesparse. The current pinned version is 5, the latest available version is 7 and the max pin pattern is x. This migration will impact 23 feedstocks.

Checklist:

  • The new version is a stable supported pin.
  • I checked that the ABI changed from 5 to 7.

**Please note that if you close this PR we presume that the new pin has been rejected.

@conda-forge-admin please ping suitesparse
This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8927712440 - please use this URL for debugging.

@regro-cf-autotick-bot regro-cf-autotick-bot requested a review from a team as a code owner May 2, 2024 17:55
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/suitesparse and so here I am doing that.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@minrk minrk merged commit 14cafaf into conda-forge:main May 6, 2024
4 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the new_pin-suitesparse-7-0-_h014e4b branch May 6, 2024 19:39
@Tobias-Fischer
Copy link
Contributor

Hi @minrk - there is no Windows version of suitesparse 7, and many packages are failing because of this, see e.g. conda-forge/colmap-feedstock#42 and conda-forge/gtsam-feedstock#24

@minrk
Copy link
Member

minrk commented May 9, 2024

Sorry, I didn't realize there had ever been a Windows build, since there weren't any windows builds in the feedstock to upgrade when I merged suitesparse 7. Apparently there hasn't been a Windows build since 5.4.0 over 4 years ago. Hopefully things have been improved since then.

Should we make the migrator leave Windows at 5 (do platform selectors work in migrators?)? Or pause the migrator altogether while we wait for a Windows build of suitesparse 7?

@minrk
Copy link
Member

minrk commented May 9, 2024

started attempt at standard Windows builds in conda-forge/suitesparse-feedstock#92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants