Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pin for libsvm #1431

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update the pin for libsvm. The current pinned version is 3.21, the latest available version is 325 and the max pin pattern is x.x. This migration will impact 2 feedstocks.

Checklist:

  • The new version is a stable supported pin.
  • I checked that the ABI changed from 3.21 to 325.

**Please note that if you close this PR we presume that the new pin has been rejected.

@conda-forge-admin please ping libsvm
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/750429367, please use this URL for debugging

@regro-cf-autotick-bot regro-cf-autotick-bot requested a review from a team as a code owner April 15, 2021 03:26
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/libsvm and so here I am doing that.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bkpoon
Copy link
Member

bkpoon commented May 27, 2021

Sorry! I've been busy with other things and have not had a chance to look at this until now. A previous PR for updating the pin for libsvm is in #1099.

The versioning should have been 321 for 3.21 (the initial recipe removes the "." when constructing the source tarball filename), and from an earlier pull request in the libsvm feedstock (conda-forge/libsvm-feedstock#7), the ABI from version 321 to 324 should not have changed (https://abi-laboratory.pro/index.php?view=timeline&l=libsvm) and there does not seem any ABI changes for 325 based on the commit history.

What kind of patch would be needed for https://github.com/conda-forge/conda-forge-repodata-patches-feedstock? It looks like I would modify gen_patch_json.py and have an entry in def _gen_new_index that looks like

if record_name == 'libsvm':
  < do something >

but it's not clear to me what to do.

Also, a secondary question. With version 325, there is now an official Python binding for libsvm named libsvm-official. Do I add the Python binding as an extra output in libsvm-feedstock or should I create a new recipe for libsvm-official?

Thanks!

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Sep 3, 2022

Jumping on old PR.

Truthfully, I don't find launching migrations to be ver disastrous. This would rebuild a few feedstocks (2 in this case) which is somewhat a good idea to avoid any errors in ABI changes that might have occured.

@hmaarrfk hmaarrfk merged commit be09fe6 into conda-forge:main Sep 3, 2022
@hmaarrfk
Copy link
Contributor

hmaarrfk commented Sep 3, 2022

I've asked for more clarification on this issue, but I feel your challenges when making PRs to the repodata patches.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Sep 3, 2022

#3368

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the new_pin-libsvm-325-0-_hd600c1 branch September 3, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants