Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win build #4

Merged
merged 20 commits into from
Oct 22, 2022
Merged

Win build #4

merged 20 commits into from
Oct 22, 2022

Conversation

Tobias-Fischer
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

@Tobias-Fischer
Copy link
Contributor Author

I think we need to wait until we have boost 1.76 in conda-forge.

@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

@Tobias-Fischer
Copy link
Contributor Author

Actually we're missing vlfeat on Win.

@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits September 12, 2022 21:48
@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits September 12, 2022 22:13
@Tobias-Fischer Tobias-Fischer changed the title Try win build Win build + boost migration Sep 12, 2022
@Tobias-Fischer
Copy link
Contributor Author

Needs conda-forge/cgal-cpp-feedstock#28

@Tobias-Fischer
Copy link
Contributor Author

@traversaro @wolfv have you this before by any chance? BLAS_LIBRARIES cannot be found on windows.

@traversaro
Copy link
Contributor

@traversaro @wolfv have you this before by any chance? BLAS_LIBRARIES cannot be found on windows.

Hi @Tobias-Fischer, at a first glance I could not find any obvious reason this is happening, I will try to debug this on a Windows machine in the next days.

@Tobias-Fischer Tobias-Fischer changed the title Win build + boost migration Win build Sep 20, 2022
@Tobias-Fischer
Copy link
Contributor Author

Hi @traversaro, did you have a chance to look at this?

@traversaro
Copy link
Contributor

Sorry, I completly forgot about this. I will look into this in the next days.

@traversaro
Copy link
Contributor

@conda-forge-admin, please rerender

@Tobias-Fischer
Copy link
Contributor Author

Tobias-Fischer commented Oct 22, 2022

Got much further after the rerender - just needs a NOMINMAX now I believe :).

@Tobias-Fischer Tobias-Fischer merged commit 43cca93 into conda-forge:main Oct 22, 2022
@traversaro
Copy link
Contributor

traversaro commented May 4, 2024

@traversaro @wolfv have you this before by any chance? BLAS_LIBRARIES cannot be found on windows.

Just replying here as today I had the same problem, but the only reference I found online was this discussion.

Basically, if you install libblas on Windows by default it installs you the mkl variant, that it is not sufficient to make find_package(BLAS) succeed. To have find_package(BLAS) succeed, you need to install the blas-devel package.

Related: conda-forge/conda-forge.github.io#2171 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants