Further PHP8 fixes, fix to variation checkbox saving

concretecms-community-store · Dec 16, 2022 · 6befaba · 6befaba
1 parent 72e3f5a
commit 6befaba
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/single_pages/dashboard/store/products.php b/single_pages/dashboard/store/products.php
@@ -1015,6 +1015,8 @@ function addtier() {
                                     <% } %>
 
                                 </div>
+                                <% } else { %>
+                                <input type="hidden" value="" name="poDisplayType[]"/>
                                 <% } %>
 
                                 <% if (poType == 'static') { %>

diff --git a/src/CommunityStore/Discount/DiscountRule.php b/src/CommunityStore/Discount/DiscountRule.php
@@ -626,9 +626,6 @@ private static function filterDiscounts($result, $cartItems = false) {
                     $count = 0;
 
                     if (is_array($cartItems)) {
-                        $discountProductGroups = [];
-
-                        $dpg = trim($row['drProductGroups']);
                         $discountProductGroups = $discountRule->getProductGroups();
 
                         if (!empty($discountProductGroups)) {

diff --git a/src/CommunityStore/Product/Product.php b/src/CommunityStore/Product/Product.php
@@ -1164,11 +1164,11 @@ public static function saveProduct($data)
         $product->setManufacturer($manufacturer);
 
 
-        // if we have no product groups, we don't have variations to offer
+        // if we have no product options, we don't have variations to offer
         if (empty($data['poName'])) {
             $product->setHasVariations(0);
         } else {
-            $product->setHasVariations(isset($data['pVariations']) ? '1' : '0');
+            $product->setHasVariations(isset($data['pVariations']) && $data['pVariations'] ? '1' : '0');
         }
 
         $product->save();