Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Success Message for Assigning Classes (PT-188181381) #1360

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Update Success Message for Assigning Classes (PT-188181381) #1360

merged 2 commits into from
Sep 16, 2024

Conversation

nstclair-cc
Copy link
Contributor

Description:

This PR addresses PT-188181381, making a small tweak to the phrasing used when an activity is successfully assigned to a class.

Changes:

  • Updated the success message text from:

    • "The activity MODS problem 1.7 is assigned to the selected class(es) successfully."

    To:

    • "The activity MODS problem 1.7 has now been successfully assigned to the selected class(es)."

This change improves clarity in the confirmation message displayed to users.

emcelroy
emcelroy approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@emcelroy emcelroy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

emcelroy
emcelroy requested changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@emcelroy emcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, have to take back my approval. Looks like a test needs to be updated to accommodate the text change.

emcelroy
emcelroy approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@emcelroy emcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nstclair-cc nstclair-cc merged commit 8806e67 into master Sep 16, 2024
10 checks passed
@nstclair-cc nstclair-cc deleted the 188181381-fix-phrasing-issue branch September 16, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emcelroy emcelroy emcelroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nstclair-cc @emcelroy